Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(admin_audit): Fix incorrect truncation of files path in admin audit log - #51681
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
…it log Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKmeforce-pushed
the
backport/50992/stable30
branch
from
March 25, 2025 10:09
14ee996 to
4f30f53Compareprovokateurin
requested changes
Mar 25, 2025
provokateurin
left a comment
Member
There was a problem hiding this comment.
Yes the file doesn't exist, because it was migrated in #47865.
You need to change this line instead:
server/apps/admin_audit/lib/Actions/Files.php
Line 209 in 6810e71
provokateurin
approved these changes
Mar 25, 2025
provokateurin
left a comment
Member
There was a problem hiding this comment.
Ah FFS should have taken one more second to check 😅
The code is already changed, it's just duplicate on master/31.
provokateurin
enabled auto-merge
March 25, 2025 10:22
come-nc
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/admin_audit/lib/Listener/FileEventListener.phpis missing - not migrated in 30