Uh oh!
There was an error while loading. Please reload this page.
[stable30] perf(sharing): Use oc_share.item_type IN instead of OR equals - #51692
Merged
Conversation
marcelklehrforce-pushed
the
backport/51669/stable30
branch
2 times, most recently
from
March 27, 2025 11:00
2c65e6f to
1db2f15Comparemarcelklehr
marked this pull request as ready for review
March 27, 2025 11:01
…equals to improve performance by using the db index Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehrforce-pushed
the
backport/51669/stable30
branch
from
March 27, 2025 11:01
1db2f15 to
1f0241fComparemarcelklehr
approved these changes
Mar 27, 2025
provokateurin
approved these changes
Mar 27, 2025
marcelklehr
commented
Mar 27, 2025
Member
🎉 |
come-nc
reviewed
Apr 1, 2025
| $qb->expr()->eq('share_type', $qb->createNamedParameter(\OCP\Share\IShare::TYPE_REMOTE_GROUP)) | ||
| ) | ||
| ); | ||
| ->where($qb->expr()->eq('share_type', $qb->createNamedParameter([IShare::TYPE_REMOTE, IShare::TYPE_REMOTE_GROUP], IQueryBuilder::PARAM_INT_ARRAY))); |
Contributor
There was a problem hiding this comment.
This eq should be in.
This is what breaks the performance job on stable30 PRs !
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51669
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.