Uh oh!
There was an error while loading. Please reload this page.
fix: filter out contacts with empty email addresses in sharee completion - #51707
Merged
Conversation
juliusknorr
requested review from
Altahrim, artonge, blizzz, nfebe, provokateurin and yemkareems
and removed request for
a teamMarch 25, 2025 22:23
ArtificialOwl
approved these changes
Mar 25, 2025
sorbaugh
approved these changes
Mar 25, 2025
juliusknorrforce-pushed
the
fix/filter-empty-email
branch
from
March 25, 2025 22:35
049825a to
f3c8e9aCompareblizzz
approved these changes
Mar 25, 2025
juliusknorrforce-pushed
the
fix/filter-empty-email
branch
from
March 25, 2025 22:35
f3c8e9a to
87e1288Comparejuliusknorr
commented
Mar 25, 2025
MemberAuthor
Using filter_var now as per feedback from @blizzz |
juliusknorr
commented
Mar 25, 2025
MemberAuthor
/backport! to stable31 |
juliusknorr
commented
Mar 25, 2025
MemberAuthor
/backport! to stable30 |
juliusknorr
commented
Mar 25, 2025
MemberAuthor
/backport! to stable29 |
1 similar comment
Pytal
commented
Mar 25, 2025
Member
/backport! to stable29 |
This was referenced Mar 25, 2025
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/51707/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 87e12884
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51707/stable29Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/51707/stable29."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
juliusknorrforce-pushed
the
fix/filter-empty-email
branch
from
March 26, 2025 10:25
1cd0b07 to
e3df2a9Compare…etion Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorrforce-pushed
the
fix/filter-empty-email
branch
from
March 26, 2025 10:51
e3df2a9 to
46f531aCompareAndyScherzinger
enabled auto-merge
March 27, 2025 22:45
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise contacts without an email address would still show up when sharing or adding them to a circle, which is not possible as there is no destination to share to