Skip to content

allow passing callbacks to registerAdmin/registerPersonal - #5173

Closed
icewind1991 wants to merge 1 commit into
masterfrom
callback-settings-pages
Closed

allow passing callbacks to registerAdmin/registerPersonal#5173
icewind1991 wants to merge 1 commit into
masterfrom
callback-settings-pages

Conversation

@icewind1991

Copy link
Copy Markdown
Member

This can be used by an app to prevent having to determine what settings pages needs to be added if the result is never used

Adjusted the files_external settings page to use the new callback option, this saved 4 db queries for each request made

This can be used by an app to prevent having to determine what settings pages needs to be added if the result is never used
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label May 30, 2017
@icewind1991icewind1991 added this to the Nextcloud 13 milestone May 30, 2017
@mention-bot

Copy link
Copy Markdown

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic, @MorrisJobke and @georgehrke to be potential reviewers.

@icewind1991

Copy link
Copy Markdown
MemberAuthor

https://github.com/nextcloud/server/pull/5173/files?w=1 for reviewing the changes without phpstorm deciding that it really wants to reformat the code

@blizzz

Copy link
Copy Markdown
Member

Can we defer it until #4890 is done? Probably it won't be necessary then at all.

@codecov

codecovBot commented May 30, 2017

Copy link
Copy Markdown

Codecov Report

Merging #5173 into master will decrease coverage by <.01%.
The diff coverage is 35.13%.

@@ Coverage Diff @@## master #5173 +/- ##
============================================
- Coverage 54.14% 54.14% -0.01% - Complexity 22286 22295 +9 
============================================
Files 1379 1379 Lines 85335 85336 +1 Branches 1321 1321 ============================================
- Hits 46208 46207 -1 - Misses 39127 39129 +2
Impacted FilesCoverage ΔComplexity Δ
lib/public/App.php23.52% <ø> (ø)8 <0> (ø)⬇️
apps/files_external/lib/AppInfo/Application.php0% <0%> (ø)7 <4> (-1)⬇️
lib/private/legacy/app.php52.49% <37.14%> (-0.93%)229 <2> (+10)
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)

@icewind1991icewind1991 mentioned this pull request Jun 1, 2017
@icewind1991

Copy link
Copy Markdown
MemberAuthor

superseded by #4890

@icewind1991
icewind1991 deleted the callback-settings-pages branch June 1, 2017 13:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@mention-bot@blizzz