Uh oh!
There was an error while loading. Please reload this page.
fix(phpunit10): Migrate away from PHPUnit at() calls - #51768
Merged
Conversation
nickvergessen
commented
Mar 27, 2025
Member
- Ref ci: Install PHPUnit 10 #48210
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
nickvergessen
requested review from
come-nc, icewind1991, nfebe and susnux
and removed request for
a teamMarch 27, 2025 22:27
susnux
approved these changes
Mar 28, 2025
This comment was marked as resolved.
This comment was marked as resolved.
nickvergessenforce-pushed
the
techdebt/noid/prepare-phpunit10
branch
from
March 28, 2025 11:52
f0b2153 to
8bc21eeCompareSigned-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
techdebt/noid/prepare-phpunit10
branch
from
March 31, 2025 07:43
8bc21ee to
522be60Comparecome-nc
reviewed
Mar 31, 2025
come-nc
left a comment
Contributor
There was a problem hiding this comment.
I would feel better if we can avoid expecting a specific default value for config keys, otherwise good job!
Uh oh!
There was an error while loading. Please reload this page.
come-nc
approved these changes
Mar 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.