Skip to content

fix(session): Only mark sessions of permanent tokens as app passwords - #51905

Merged
susnux merged 1 commit into
masterfrom
fix/session/permanent-token-app-password
Apr 3, 2025
Merged

fix(session): Only mark sessions of permanent tokens as app passwords#51905
susnux merged 1 commit into
masterfrom
fix/session/permanent-token-app-password

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Apr 3, 2025•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

This fixes a logic error of #24552. As noticed in nextcloud/globalsiteselector#51 (comment) the check should be on the token type, not the remember property.

How to test

  1. Log into a session without remember me

master: app_password key is saved to the session
here: app_password key does not exist in session

TODO

  • Do

Checklist

@ChristophWurst
fix(session): Only mark sessions of permanent tokens as app passwords
5003467
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added bug 3. to review Waiting for reviews labels Apr 3, 2025
@ChristophWurstChristophWurst added this to the Nextcloud 32 milestone Apr 3, 2025
@ChristophWurstChristophWurst self-assigned this Apr 3, 2025
@ChristophWurst
ChristophWurst requested a review from a team as a code ownerApril 3, 2025 08:10
@ChristophWurst
ChristophWurst requested review from Altahrim, come-nc and nfebe and removed request for a teamApril 3, 2025 08:10
@ChristophWurst

ChristophWurst commented Apr 3, 2025

Copy link
Copy Markdown
MemberAuthor

/backport! to stable31

@ChristophWurst

ChristophWurst commented Apr 3, 2025

Copy link
Copy Markdown
MemberAuthor

/backport! to stable30

@ChristophWurst

ChristophWurst commented Apr 3, 2025

Copy link
Copy Markdown
MemberAuthor

/backport! to stable29

@backportbotbackportbotBot mentioned this pull request Apr 3, 2025
Merged
This was referenced Apr 3, 2025
Merged
Merged
@susnux
susnux merged commit 8f6386d into masterApr 3, 2025
@susnux
susnux deleted the fix/session/permanent-token-app-password branch April 3, 2025 09:31
@github-project-automationgithub-project-automationBot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware teamApr 3, 2025
@ChristophWurstChristophWurst mentioned this pull request Apr 9, 2025
Merged
This was referenced Apr 9, 2025
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@st3inyst3inyst3iny approved these changes
@susnuxsusnuxsusnux approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@ChristophWurstChristophWurst

Labels

3. to reviewWaiting for reviewsbug

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@AndyScherzinger@st3iny@susnux@skjnldsv