Uh oh!
There was an error while loading. Please reload this page.
fix(systemtags): emit assign and unassign bulk tagging events - #51927
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
ArtificialOwl, artonge and come-nc
and removed request for
a teamApril 4, 2025 02:33
skjnldsv
commented
Apr 4, 2025
MemberAuthor
/backport to stable31 |
susnux
reviewed
Apr 4, 2025
| // Dispatch unassign events for removed object ids | ||
| foreach ($removedObjectIds as $objectId) { | ||
| $this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent( |
Contributor
There was a problem hiding this comment.
we do not have typed events for this? 👀
Something we should fix rather sooner than later before we have to drop the untyped dispatch due to symphony update.
susnux
approved these changes
Apr 4, 2025
4 tasks
artonge
approved these changes
Apr 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#51849