Skip to content

fix(cache): always require updates if mtime is null - #51942

Merged
susnux merged 1 commit into
masterfrom
fix/require-update-if-mtime-is-null
Apr 7, 2025
Merged

fix(cache): always require updates if mtime is null#51942
susnux merged 1 commit into
masterfrom
fix/require-update-if-mtime-is-null

Conversation

@susnux

@susnuxsusnux commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Summary

Due to strong typings we introduced the parameter needs to be an integer. Previously it was null which was equal to 0. So if there is no storage mtime we need to update the cache.

Checklist

@susnux
fix(cache): always require updates if mtime is null
3a09ace
- Resolves#51941
Due to strong typings we introduced the parameter needs to be an
integer. Previously it was `null` which was equal to `0`.
So if there is no storage mtime we need to update the cache.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux requested a review from a team as a code ownerApril 4, 2025 11:48
@susnux
susnux requested review from Altahrim, skjnldsv and sorbaugh and removed request for a teamApril 4, 2025 11:48
@susnux

susnux commented Apr 4, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@susnux
susnux requested review from come-nc and removed request for sorbaughApril 4, 2025 14:41
@susnux
susnux merged commit 1ef9415 into masterApr 7, 2025
@susnux
susnux deleted the fix/require-update-if-mtime-is-null branch April 7, 2025 08:17
@backportbotbackportbotBot mentioned this pull request Apr 7, 2025
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@come-nccome-nccome-nc approved these changes
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
+1 more reviewer
@yemkareemsyemkareemsyemkareems approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: "OC\\Files\\Storage\\Wrapper\\Wrapper::hasUpdated(): Argument #2 ($time) must be of type int" when uploading files via "share" from iOS

4 participants

@susnux@skjnldsv@yemkareems@come-nc