Skip to content

fix(files_reminders): add missing import - #51944

Merged
kesselb merged 3 commits into
masterfrom
fix/missing-import
Apr 7, 2025
Merged

fix(files_reminders): add missing import#51944
kesselb merged 3 commits into
masterfrom
fix/missing-import

Conversation

@susnux

@susnuxsusnux commented Apr 4, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  1. Add missing import of setup check in application class
  2. Add missing l10n constructor parameter.
  3. Lint the app using psalm so this does not happen again.

Checklist

@susnux
susnux requested a review from a team as a code ownerApril 4, 2025 14:31
@susnux
susnux requested review from ArtificialOwl, artonge, nfebe and yemkareems and removed request for a teamApril 4, 2025 14:31
@susnuxsusnux added this to the Nextcloud 31.0.3 milestone Apr 4, 2025
@susnux

susnux commented Apr 4, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@susnux

susnux commented Apr 4, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

susnux commented Apr 4, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable29

@susnuxsusnux mentioned this pull request Apr 4, 2025
Merged
kesselb
kesselb previously requested changes Apr 7, 2025
View reviewed changes
Comment threadapps/files_reminders/lib/AppInfo/Application.php Outdated
come-nc
come-nc reviewed Apr 7, 2025
View reviewed changes
Comment threadapps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php Outdated
@@ -10,12 +10,14 @@
namespace OCA\DAV\SetupChecks;

@come-nccome-ncApr 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed that’s worrying. We have no check for namespace<>path consistency?

@susnuxsusnuxApr 7, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can psalm do this?

susnux added 3 commits April 7, 2025 10:56
@susnux
fix(files_reminders): add missing import
a682049
- Resolves#51943
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files_reminders): add l10n to constructor of setup check
d79070c
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: lint files_reminders using psalm
c0212af
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/missing-import branch from 8f3abc4 to c0212afCompareApril 7, 2025 08:56
@susnux
susnux requested review from come-nc and kesselbApril 7, 2025 08:56
@kesselb
kesselb merged commit 07278d2 into masterApr 7, 2025
@kesselb
kesselb deleted the fix/missing-import branch April 7, 2025 09:38
This was referenced Apr 7, 2025
Merged
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@kesselbkesselbAwaiting requested review from kesselb
@come-nccome-ncAwaiting requested review from come-nc
+1 more reviewer
@yemkareemsyemkareemsyemkareems approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugregression

Projects

None yet

Milestone

Nextcloud 31.0.3

Development

Successfully merging this pull request may close these issues.

[Bug]: Could not resolve OCA\FilesReminders\AppInfo\NeedNotificationsApp

6 participants

@susnux@kesselb@artonge@skjnldsv@yemkareems@come-nc