fix(workflowengine): fix group not shown in Group membership check

[blizzz]

Summary

this might have occured on instances with

• more than twenty groups, and
• on rules with more than one Group membership checks
• and at least one of them being not in the set of the first 20 groups

before	after

In the before image you see that in some Group membership checks are still the placeholders and only two groups, G13 and G14 are shown with their display names. The network console shows that only the first twenty groups were fetched.

In the after image you see that all groups are visible now. The groups G33 and G37 are used twice each, on in combination with themselves and once an a rule with another group. In the network console you see that these groups are fetched now, but just once, not more than necessary.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nfebe]

Easier to read.

Suggested change

	let nextQuery
	do {
	nextQuery = this.wantedGroups.shift()
	if (this.hasGroup(nextQuery)) {
	nextQuery = undefined
	}
	} while (!nextQuery && this.wantedGroups.length > 0)
	if (nextQuery) {
	await this.searchAsync(nextQuery)
	}
	while (this.wantedGroups.length > 0) {
	const groupId = this.wantedGroups.shift()
	if (this.hasGroup(groupId)) {
	continue
	}
	await this.searchAsync(groupId)
	return
	}

Also, the current implementation would only search 1 wanted group, I assuming this intended as this.findGroupByQueue() again called at the end of search

[blizzz]

This was intentionally done as a queue in order to not DoS the server with group search requests, but have them coming sequentially.

[susnux]

works but see Fons comments

[blizzz]

/compile amend /

[blizzz]

(Rebased and rebuild)