Uh oh!
There was an error while loading. Please reload this page.
fix: disable direct download for shares - #52133
Merged
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
artonge, provokateurin and yemkareems
and removed request for
a teamApril 11, 2025 15:44
artonge
approved these changes
Apr 14, 2025
Collaborator
There was a problem hiding this comment.
Not sure about the reason for such method in the first place. But isn't it the default anyway?
server/lib/private/Files/Storage/Common.php
Lines 452 to 454 in b90c7b3
icewind1991
commented
May 8, 2025
MemberAuthor
For storage wrappers, it defaults to forwarding the call to the underlying storage. Which for shared storage means doing the full share setup. |
yemkareems
approved these changes
May 8, 2025
icewind1991
commented
May 8, 2025
MemberAuthor
/backport to stable31 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not aware of any storage backend that implements this but this still requires setting up the share source to forward the call currently.
Additionally I'm unsure if shares should even use the same direct download link as their source.