Skip to content

fix(files_sharing): bring back handling of hide-download on public shares - #52180

Merged
susnux merged 6 commits into
masterfrom
fix/bring-back-hide-downlaod
Apr 16, 2025
Merged

fix(files_sharing): bring back handling of hide-download on public shares#52180
susnux merged 6 commits into
masterfrom
fix/bring-back-hide-downlaod

Conversation

@susnux

@susnuxsusnux commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Summary

This includes also some features as we need a WebDAV property for the hide-download functionality,
in legacy sharing interface it was passed as some kind of state, but with the Vue files interface we need a node attribute.

Best to review each commit separately.

Checklist

@susnuxsusnux added this to the Nextcloud 32 milestone Apr 14, 2025
Comment threadapps/dav/lib/Connector/Sabre/FilesPlugin.php
@susnux
susnuxforce-pushed the fix/bring-back-hide-downlaod branch from 2bf2439 to 3401468CompareApril 14, 2025 15:23
@susnux
susnux marked this pull request as ready for review April 14, 2025 15:45
@susnux
susnux requested review from a team and skjnldsv as code ownersApril 14, 2025 15:45
@susnux
susnux requested review from artonge and sorbaugh and removed request for a teamApril 14, 2025 15:45
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php
Comment threadapps/files_sharing/src/models/Share.ts

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI : The was some feedback from @danxuliu here: #50897

Mentioning it case it is possible to align some or all of it.

Also, since the switch was not preventing download, is there a way for those who used to switch do undo it if they can identify the shares on which it was applied?

@susnux

Copy link
Copy Markdown
ContributorAuthor

FYI : The was some feedback from @danxuliu here: #50897

yes that covered by the webdav property

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI : The was some feedback from @danxuliu here: #50897

yes that covered by the webdav property

As the hideDownload element is no longer provided please note that this pull request alone is not enough to bring back the old behaviour. Any app that used the hideDownload element must be updated to get the value from the new WebDAV property instead (so this should be documented somewhere).

For the PDF viewer I adjusted it in the last commit of nextcloud/files_pdfviewer#1164

…e of shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… enabled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

Copy link
Copy Markdown
ContributorAuthor

PR to viewer will be created right after merge

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Hide download" in public shares is no longer "hide download" but "prevent download" in Nextcloud 31

6 participants

@susnux@artonge@nfebe@danxuliu@szaimen@skjnldsv