Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): bring back handling of hide-download on public shares - #52180
Conversation
Uh oh!
There was an error while loading. Please reload this page.
2bf2439 to
3401468CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
susnux
commented
Apr 15, 2025
/backport to stable31 |
susnux
commented
Apr 15, 2025
danxuliu
left a comment
There was a problem hiding this comment.
yes that covered by the webdav property
As the hideDownload element is no longer provided please note that this pull request alone is not enough to bring back the old behaviour. Any app that used the hideDownload element must be updated to get the value from the new WebDAV property instead (so this should be documented somewhere).
For the PDF viewer I adjusted it in the last commit of nextcloud/files_pdfviewer#1164
…e of shares Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… action Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… enabled Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
commented
Apr 16, 2025
PR to viewer will be created right after merge |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
3401468 to
e5291caCompare
Summary
This includes also some features as we need a WebDAV property for the
hide-downloadfunctionality,in legacy sharing interface it was passed as some kind of state, but with the Vue files interface we need a node attribute.
Best to review each commit separately.
Checklist