Uh oh!
There was an error while loading. Please reload this page.
perf(carddav): don't query circle memberships - #52215
Merged
Merged
Conversation
It is not possible to share address books with circles so it is pointless to query for address books shared with joined circles. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
tcitworld
commented
Apr 17, 2025
Member
Yeah, it got added with #6512, pretty sure it was intended to have it soon in the contacts app as well, but never occurred. |
st3iny
commented
Apr 17, 2025
MemberAuthor
Looking at the PR it really seems to be an incomplete feature. I think we can move on with this. I looked at some profiles from real world requests and loading circles is taking a lot of time. |
kesselb
approved these changes
Apr 28, 2025
SebastianKrupinski
approved these changes
Jun 1, 2025
AndyScherzinger
commented
Jun 1, 2025
Member
@st3iny something to backport then? 31? |
st3iny
commented
Jun 2, 2025
MemberAuthor
/backport to stable30 |
st3iny
commented
Jun 2, 2025
MemberAuthor
/backport to stable31 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is not possible to share address books with circles so it is pointless to query for address books shared with joined circles.
Checklist