Skip to content

fix(settings): allow to clear twitter and fediverse - #52250

Merged
susnux merged 3 commits into
masterfrom
fix/twitter-fediverse
Apr 27, 2025
Merged

fix(settings): allow to clear twitter and fediverse#52250
susnux merged 3 commits into
masterfrom
fix/twitter-fediverse

Conversation

@susnux

@susnuxsusnux commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Summary

Allow to unset social media properties (allow empty string).

Checklist

@susnuxsusnux added bug 3. to review Waiting for reviews regression feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Apr 17, 2025
@susnuxsusnux added this to the Nextcloud 32 milestone Apr 17, 2025
@susnux
susnux requested a review from a team as a code ownerApril 17, 2025 11:15
@susnux
susnux requested review from nfebe, skjnldsv and szaimen and removed request for a teamApril 17, 2025 11:15
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable30

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv

Copy link
Copy Markdown
Member

/compile

@skjnldsv
skjnldsvforce-pushed the fix/twitter-fediverse branch from 806d0e6 to 5e2f52dCompareApril 25, 2025 10:02
@skjnldsv

Copy link
Copy Markdown
Member

failure is related

susnuxand others added 2 commits April 27, 2025 14:15
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the fix/twitter-fediverse branch from 0eccbc4 to 02da7fdCompareApril 27, 2025 12:15
@susnux

Copy link
Copy Markdown
ContributorAuthor

failure is related

yes but luckily just the test code :)
✅ fixed it

@susnux
susnux enabled auto-merge April 27, 2025 12:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: profilePRs or issues related to the Profile feature (e.g. Profile page, API, etc.)regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cant remove Social Media profiles in User Account

5 participants

@susnux@skjnldsv@szaimen@nextcloud-command@AndyScherzinger