Skip to content

fix(files): make sure to always have proper plural forms - #52269

Merged
susnux merged 2 commits into
masterfrom
fix/files-summary
Apr 30, 2025
Merged

fix(files): make sure to always have proper plural forms#52269
susnux merged 2 commits into
masterfrom
fix/files-summary

Conversation

@susnux

@susnuxsusnux commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Summary

counted words should always be translated using n. We can still simply concat the segments with punctuation, this always works regardless of the language used (even with RTL / LTR languages).

Checklist

@susnuxsusnux added bug 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Apr 18, 2025
@susnuxsusnux added this to the Nextcloud 32 milestone Apr 18, 2025
@susnux
susnux requested review from a team and skjnldsv as code ownersApril 18, 2025 22:38
@susnux
susnux requested review from nfebe and szaimen and removed request for a teamApril 18, 2025 22:38
skjnldsv
skjnldsv approved these changes Apr 22, 2025
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, much simpler. 🙈

@susnux
fix(files): make sure to always have proper plural forms
04f7d4a
counted words should always be translated using `n`.
We can still simply concat the segments with punctation, this always
works regardless of the language used (even with RTL / LTR languages).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

susnux commented Apr 30, 2025

Copy link
Copy Markdown
ContributorAuthor

/compile

@nextcloud-command
chore(assets): Recompile assets
0fb8daa
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit df69eb5 into masterApr 30, 2025
@susnux
susnux deleted the fix/files-summary branch April 30, 2025 17:11
@susnux

susnux commented May 20, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@backportbotbackportbotBot mentioned this pull request May 20, 2025
Merged
2 tasks
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: language/translations (l10n/i18n)Localization and translation matters

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[l10n] Singular and plural

4 participants

@susnux@AndyScherzinger@skjnldsv@nextcloud-command