fix(metadata): set background job on fresh setup

[ArtificialOwl]

until now, only an upgrade will add the job to the list:

https://github.com/nextcloud/server/blob/master/lib/private/Repair/AddMetadataGenerationJob.php#L24

The background job is mainly to create metadata on files added previously to the upgrade that implemented the FilesMetadata feature.
This background job is useless on fresh setup that already implement the feature.
Adding the background job on fresh setup instead of waiting for the next execution of the Repair Step disable the huge process at first upgrade once the cloud and filesystem are filled with users+documents

[ArtificialOwl]

/backport to stable31

[ArtificialOwl]

/backport to stable30

[provokateurin]

Makes sense 🙈

[provokateurin]

@ArtificialOwl 29 is EOL so no backports anymore ;)

[come-nc]

The background job is mainly to create metadata on files added previously to the upgrade that implemented the FilesMetadata feature. This background job is useless on fresh setup that already implement the feature. Adding the background job on fresh setup instead of waiting for the next execution of the Repair Step disable the huge process at first upgrade once the cloud and filesystem are filled with users+documents

I do not understand, if the job is useless on fresh setup, why add it 🤔

[ArtificialOwl]

The background job is mainly to create metadata on files added previously to the upgrade that implemented the FilesMetadata feature. This background job is useless on fresh setup that already implement the feature. Adding the background job on fresh setup instead of waiting for the next execution of the Repair Step disable the huge process at first upgrade once the cloud and filesystem are filled with users+documents

I do not understand, if the job is useless on fresh setup, why add it 🤔

to not restart the job with more files later

[come-nc]

I do not understand, if the job is useless on fresh setup, why add it 🤔

to not restart the job with more files later

How does that prevent it?

[ArtificialOwl]

I do not understand, if the job is useless on fresh setup, why add it 🤔

to not restart the job with more files later

How does that prevent it?

The background job will set a value in appconfig once over
https://github.com/nextcloud/server/blob/master/core/BackgroundJobs/GenerateMetadataJob.php#L76

There is no need to run it on the next upgrade because Metadata are generated on the fly during file creation

[come-nc]

I do not understand, if the job is useless on fresh setup, why add it 🤔

to not restart the job with more files later

How does that prevent it?

The background job will set a value in appconfig once over https://github.com/nextcloud/server/blob/master/core/BackgroundJobs/GenerateMetadataJob.php#L76

There is no need to run it on the next upgrade because Metadata are generated on the fly during file creation

Feels like it would’ve been easier to set the value than add a background job for it, but okay.

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/52375/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 65a2b3b6
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52375/stable30

Error: Failed to push branch backport/52375/stable30: remote: Invalid username or password.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[solracsf]

/backport to stable30