Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(files_sharing): Improve expiration date input change handling - #52407
Merged
Conversation
miaulalala
commented
Apr 24, 2025
Contributor
/compile amend / |
nextcloud-commandforce-pushed
the
backport/52364/stable29
branch
from
April 24, 2025 15:25
6c52a6a to
d9e6d56Comparenfebe
commented
Apr 24, 2025
Contributor
/compile amend |
nfebeforce-pushed
the
backport/52364/stable29
branch
from
April 24, 2025 18:51
d9e6d56 to
5f62b6aComparenfebe
marked this pull request as ready for review
April 24, 2025 18:51
nfebe
enabled auto-merge
April 24, 2025 18:51
nfebe
approved these changes
Apr 24, 2025
If the time picker component is emitting a Date object already, then there is redundant call of `new Date(new Date())` and therefore introduces subtle bugs, for example on chrome users could not enter expiration date with keyboard. - Use @update:model-value instead of @change/@input for more reliable date updates - Ensure null and invalid dates are handled correctly in onExpirationChange - Validate date input before updating defaultExpirationDateEnabled Resolves : #51875 Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/52364/stable29
branch
from
April 24, 2025 18:55
5f62b6a to
628d7feComparesusnux
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52364
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.