Skip to content

fix(occ): Fix autocompletion of config:app:* commands - #52429

Merged
provokateurin merged 1 commit into
masterfrom
bugfix/noid/fix-autocomplete-of-app-configs
Apr 25, 2025
Merged

fix(occ): Fix autocompletion of config:app:* commands#52429
provokateurin merged 1 commit into
masterfrom
bugfix/noid/fix-autocomplete-of-app-configs

Conversation

@nickvergessen

@nickvergessennickvergessen commented Apr 25, 2025

Copy link
Copy Markdown
Member

Before

occ config:app:get spreed An unhandled exception has been thrown:
Error: Call to a member function getAppKeys() on null in /…/server/core/Command/Config/App/Base.php:31
Stack trace:
#0 /…/server/3rdparty/stecman/symfony-console-completion/src/CompletionHandler.php(299): OC\Core\Command\Config\App\Base->completeArgumentValues('...', Object(Stecman\Component\Symfony\Console\BashCompletionvironmentCompletionContext))
#1 /…/server/3rdparty/stecman/symfony-console-completion/src/CompletionHandler.php(122): Stecman\Component\Symfony\Console\BashCompletion\CompletionHandler->completeForCommandArguments()
#2 /…/server/3rdparty/stecman/symfony-console-completion/src/CompletionCommand.php(184): Stecman\Component\Symfony\Console\BashCompletion\CompletionHandler->runCompletion()
#3 /…/server/3rdparty/stecman/symfony-console-completion/src/CompletionCommand.php(123): Stecman\Component\Symfony\Console\BashCompletion\CompletionCommand->runCompletion()
#4 /…/server/3rdparty/symfony/console/Command/Command.php(326): Stecman\Component\Symfony\Console\BashCompletion\CompletionCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#5 /…/server/3rdparty/symfony/console/Application.php(1078): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /…/server/3rdparty/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(Stecman\Component\Symfony\Console\BashCompletion\CompletionCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /…/server/3rdparty/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 /…/server/lib/private/Console/Application.php(187): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /…/server/console.php(87): OC\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput))
#10 /…/server/occ(33): require_once('...')
#11 {main}

After

occ config:app:get spreed enabled installed_version signaling_dev signaling_token_privkey_es256 sip_bridge_dialin_info sip_dialout
federation_enabled recording_servers signaling_servers signaling_token_pubkey_es256 sip_bridge_shared_secret types

Checklist

@nickvergessennickvergessen added this to the Nextcloud 32 milestone Apr 25, 2025
@nickvergessennickvergessen self-assigned this Apr 25, 2025
@nickvergessen
nickvergessen requested a review from a team as a code ownerApril 25, 2025 09:29
@nickvergessen
nickvergessen requested review from provokateurin and removed request for a teamApril 25, 2025 09:29
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the bugfix/noid/fix-autocomplete-of-app-configs branch from b154c11 to 7962df9CompareApril 25, 2025 09:30
@provokateurin
provokateurin merged commit 84e9aff into masterApr 25, 2025
@provokateurin
provokateurin deleted the bugfix/noid/fix-autocomplete-of-app-configs branch April 25, 2025 12:18
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: occ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@blizzz@Altahrim@provokateurin@skjnldsv