Uh oh!
There was an error while loading. Please reload this page.
fix: don't check node access again for listing reminders in dav - #52443
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
AndyScherzinger
commented
Apr 25, 2025
Member
/backport to stable31 |
AndyScherzinger
commented
Apr 25, 2025
Member
/backport to stable30 |
come-nc
approved these changes
Apr 28, 2025
AndyScherzinger
enabled auto-merge
April 28, 2025 09:12
artonge
approved these changes
Apr 28, 2025
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/52443/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 3d36625a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52443/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a performance regression from #50711 (review)
The dav propfind will have already made sure we have access to the node.
The check is left in place for other callers