Uh oh!
There was an error while loading. Please reload this page.
[stable31] fix(files_sharing): Show remote shares as external - #52498
Merged
Conversation
nfebe
marked this pull request as ready for review
April 28, 2025 10:05
nfebe
enabled auto-merge
April 28, 2025 10:05
nfebe
commented
Apr 28, 2025
Contributor
/compile amend |
nfebe
approved these changes
Apr 28, 2025
nfebe
disabled auto-merge
April 28, 2025 10:07
nextcloud-commandforce-pushed
the
backport/52423/stable31
branch
from
April 28, 2025 10:09
90d6036 to
f8c65d7Comparemaximelehericy
commented
Apr 28, 2025
as discussed with @nfebe, please hold this backport until discussion about customers impact have happened 🙏 |
AndyScherzinger
requested changes
Apr 28, 2025
AndyScherzinger
left a comment
Member
There was a problem hiding this comment.
needs a config flag to switch the behavior to have this in "internal" shares
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
backport/52423/stable31
branch
from
May 6, 2025 14:33
f8c65d7 to
5788dfaComparenfebe
commented
May 6, 2025
Contributor
/compile |
Replaced multiple Array.filter() calls with a single loop to improve performance. This avoids redundant iterations over the shares array and categorizes them more efficiently. Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
nfebeforce-pushed
the
backport/52423/stable31
branch
from
May 6, 2025 14:37
5788dfa to
6873632Comparenfebe
commented
May 6, 2025
Contributor
Included : #52511 |
nfebe
enabled auto-merge
May 6, 2025 14:38
nfebe
commented
May 6, 2025
Contributor
/compile |
…g input - Fix autoloading for new `ConfigLexicon` - Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`: This is important, because when federated shares are shown as internal the users should add them from the internal shares section Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebeforce-pushed
the
backport/52423/stable31
branch
from
May 6, 2025 14:54
e07c389 to
d616a73CompareAndyScherzinger
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52423
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.