Skip to content

Fix theme logo position and shape - #525

Merged
nickvergessen merged 4 commits into
masterfrom
fix-theme-logo-position
Jul 26, 2016
Merged

Fix theme logo position and shape#525
nickvergessen merged 4 commits into
masterfrom
fix-theme-logo-position

Conversation

@jospoortvliet

@jospoortvlietjospoortvliet commented Jul 22, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Fix from #344 (comment)

  • fix logo in top bar
  • fix logo on login
    Working:
  • logo's that are higher than wide:
    spectacle i10431
    spectacle p10431
  • square-ish ones:
    spectacle n10431
    spectacle q10431

Still broken:

  • upon first apply, the logo is stretched. Can't figure out why, a reload fixes it and makes it look good.
    spectacle e10431
  • logo's which are wider are top-aligned, can't get them to vertically center:
    spectacle m10376

I can't figure out how to fix those. Leave it up to somebody with actual CSS fu.

@mention-bot

mention-bot commented Jul 22, 2016

Copy link
Copy Markdown

@jospoortvliet, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @schiessle and @juliushaertl to be potential reviewers

@MorrisJobke

MorrisJobke commented Jul 22, 2016

Copy link
Copy Markdown
Member

cc @jancborchardt

Jos Poortvliet
Update header.css
642f59e
make the logo look good on the login page
@jospoortvlietjospoortvliet changed the title Update themingcontroller.phpFix theme logo position and shapeJul 22, 2016
@LukasReschke

LukasReschke commented Jul 22, 2016

Copy link
Copy Markdown
Member

Awesome. I'll hijack to fix the unit tests, @jospoortvliet :-)

@LukasReschkeLukasReschke self-assigned this Jul 22, 2016
@LukasReschkeLukasReschke added this to the Nextcloud 11.0 milestone Jul 22, 2016
@LukasReschkeLukasReschke added the 2. developing Work in progress label Jul 22, 2016
@LukasReschkeLukasReschke removed their assignment Jul 22, 2016
@LukasReschke

LukasReschke commented Jul 22, 2016

Copy link
Copy Markdown
Member

Tests adjusted at 8457c61, now I'll leave that to the CSS gurus 😉

@juliusknorr

juliusknorr commented Jul 25, 2016

Copy link
Copy Markdown
Member

I'll take over to fix the remaining css issues.

@juliusknorr

juliusknorr commented Jul 25, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Should be done:

  • Fixed preview alignment
  • wider logos are now centered

I guess this is now ready for review.

@juliusknorrjuliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 25, 2016
@go2sh

go2sh commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

Backport would be nice.

@MorrisJobke

MorrisJobke commented Jul 26, 2016

Copy link
Copy Markdown
Member

Tested and works 👍

@MorrisJobke

MorrisJobke commented Jul 26, 2016

Copy link
Copy Markdown
Member

@rullzer@Mar1u5@nickvergessen@schiessle Review would be nice :)

@schiessle

schiessle commented Jul 26, 2016

Copy link
Copy Markdown
Member

looks good 👍

@schiessleschiessle added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2016
@nickvergessen
nickvergessen merged commit cc5ddcf into masterJul 26, 2016
@nickvergessen
nickvergessen deleted the fix-theme-logo-position branch July 26, 2016 08:46
@MorrisJobkeMorrisJobke mentioned this pull request Jul 26, 2016
Closed
@MorrisJobke

MorrisJobke commented Jul 26, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Backport would be nice.

cc @karlitschek

@karlitschek

karlitschek commented Jul 26, 2016

Copy link
Copy Markdown
Member

cool. please backport 👍

@juliusknorr

juliusknorr commented Jul 26, 2016

Copy link
Copy Markdown
Member

I'll create a backport for this, just for Nextcloud 10 or also for Nextcloud 9 @karlitschek@MorrisJobke

@karlitschek

karlitschek commented Jul 26, 2016

Copy link
Copy Markdown
Member

i think both would be good

This was referenced Jul 26, 2016
Merged
Merged
@jancborchardt

jancborchardt commented Jul 26, 2016

Copy link
Copy Markdown
Member

Awesome work @juliushaertl! :)

@jancborchardtjancborchardt mentioned this pull request Jul 28, 2016
Closed
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: theming

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

10 participants

@jospoortvliet@mention-bot@MorrisJobke@LukasReschke@juliusknorr@go2sh@schiessle@karlitschek@jancborchardt@nickvergessen