Skip to content

fix(files_sharing): Filter own shares that are reshares - #52503

Merged
provokateurin merged 1 commit into
masterfrom
fix/files_sharing/filter-own-reshared-shares
May 19, 2025
Merged

fix(files_sharing): Filter own shares that are reshares#52503
provokateurin merged 1 commit into
masterfrom
fix/files_sharing/filter-own-reshared-shares

Conversation

@provokateurin

@provokateurinprovokateurin commented Apr 28, 2025

Copy link
Copy Markdown
Member

Summary

Shares were only filtered if the current user is the owner, but in a reshare they are not the owner.

Checklist

@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels Apr 28, 2025
@provokateurinprovokateurin added this to the Nextcloud 32 milestone Apr 28, 2025
@provokateurin
provokateurin requested a review from a team as a code ownerApril 28, 2025 12:43
@provokateurin
provokateurin requested review from Altahrim, skjnldsv and yemkareems and removed request for a teamApril 28, 2025 12:43
@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@provokateurin
provokateurin requested review from a team and come-ncMay 5, 2025 13:48
This was referenced May 6, 2025
@susnux

Copy link
Copy Markdown
Contributor

(tests would be nice to test the difference between before and after)

Comment threadapps/files_sharing/lib/MountProvider.php Outdated
@provokateurin
provokateurinforce-pushed the fix/files_sharing/filter-own-reshared-shares branch from 2b402dc to 9269a8bCompareMay 6, 2025 11:25
@provokateurin
provokateurin requested a review from come-ncMay 6, 2025 11:26
@blizzz

Copy link
Copy Markdown
Member

The same tests fails three times in a row:

Screenshot_20250506_174147

Not sure whether related, but could be.

@provokateurin

Copy link
Copy Markdown
MemberAuthor

It's related, I'm working on it.

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurinforce-pushed the fix/files_sharing/filter-own-reshared-shares branch from 9269a8b to 7c6602cCompareMay 19, 2025 06:18
@provokateurin
provokateurin merged commit 9fa0477 into masterMay 19, 2025
@provokateurin
provokateurin deleted the fix/files_sharing/filter-own-reshared-shares branch May 19, 2025 08:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Reshare with (own) group ends up as double share for sharee

6 participants

@provokateurin@susnux@blizzz@skjnldsv@yemkareems@come-nc