Skip to content

[stable30] fix(files_sharing): Prevent create/delete permissions on file shares - #52530

Merged
nfebe merged 1 commit into
stable30from
backport/52526/stable30
Apr 29, 2025
Merged

[stable30] fix(files_sharing): Prevent create/delete permissions on file shares#52530
nfebe merged 1 commit into
stable30from
backport/52526/stable30

Conversation

@backportbot

@backportbotbackportbotBot commented Apr 29, 2025

Copy link
Copy Markdown

Backport of #52526

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nfebe
nfebe marked this pull request as ready for review April 29, 2025 13:07
@nfebe
nfebe enabled auto-merge April 29, 2025 13:07
@nfebe

Copy link
Copy Markdown
Contributor

/compile amend

File shares can't support create or delete permissions. This change ensures those permissions are
stripped or ignored when the shared item is not a folder.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe
nfebe requested a review from sorbaughApril 29, 2025 14:02
@nfebe
nfebe merged commit e902fec into stable30Apr 29, 2025
@nfebe
nfebe deleted the backport/52526/stable30 branch April 29, 2025 14:13
@blizzzblizzz mentioned this pull request May 5, 2025
10 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Sep 18, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 25, 2025
2 tasks
@blizzzblizzz mentioned this pull request Oct 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nfebe@susnux