Skip to content

fix(files_sharing): bring back owner and ownerDisplayName initial state - #52532

Merged
skjnldsv merged 1 commit into
masterfrom
fix/public-displayname-owner
Apr 30, 2025
Merged

fix(files_sharing): bring back owner and ownerDisplayName initial state#52532
skjnldsv merged 1 commit into
masterfrom
fix/public-displayname-owner

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Regression from #45652

It's still being used in

owner: loadState('files_sharing', 'owner', ''),
ownerDisplayName: loadState('files_sharing', 'ownerDisplayName', ''),
label: loadState('files_sharing', 'label', ''),
note: loadState('files_sharing', 'note', ''),
filename: loadState('files_sharing', 'filename', ''),

@skjnldsvskjnldsv added this to the Nextcloud 32 milestone Apr 29, 2025
@skjnldsvskjnldsv self-assigned this Apr 29, 2025
@skjnldsv
skjnldsv requested a review from a team as a code ownerApril 29, 2025 14:26
@skjnldsv
skjnldsv requested review from artonge, nfebe and provokateurin and removed request for a teamApril 29, 2025 14:26
@skjnldsv
skjnldsvforce-pushed the fix/public-displayname-owner branch from f06d0c4 to ab5895aCompareApril 29, 2025 14:26
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@skjnldsv
skjnldsvforce-pushed the fix/public-displayname-owner branch from ab5895a to c9e64e4CompareApril 29, 2025 14:45
@susnux

susnux commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

It's still being used in

Cant we just use the owner of the root file? That way we do not need any custom initial state
No this is show earlier.

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/public-displayname-owner branch from c9e64e4 to bcc8de0CompareApril 29, 2025 19:25
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Cant we just use the owner of the root file? That way we do not need any custom initial state No this is show earlier.

I'm currently working in related areas. So I'd like to have this fix in at least.
Maybe I'll improve the way we handle this in the future, but I'd say it's not the priority here :)

@skjnldsv
skjnldsv merged commit 57e0ffc into masterApr 30, 2025
@skjnldsv
skjnldsv deleted the fix/public-displayname-owner branch April 30, 2025 09:32
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@susnux@artonge@nfebe@provokateurin