Uh oh!
There was an error while loading. Please reload this page.
feat(files_sharing): show Account menu on public pages - #52537
Merged
Conversation
skjnldsvforce-pushed
the
fix/loading-account-menu
branch
from
May 2, 2025 14:48
1733f8f to
1527c5eCompareskjnldsvforce-pushed
the
fix/loading-account-menu
branch
3 times, most recently
from
May 15, 2025 16:40
22d454e to
7600d21Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
marked this pull request as ready for review
May 16, 2025 07:36
skjnldsv
requested review from
artonge, provokateurin, sorbaugh and susnux
and removed request for
a teamMay 16, 2025 07:36
This comment was marked as resolved.
This comment was marked as resolved.
nextcloud-commandforce-pushed
the
fix/loading-account-menu
branch
from
May 16, 2025 07:40
7600d21 to
6ca71cfCompareUh oh!
There was an error while loading. Please reload this page.
come-nc
commented
May 16, 2025
Contributor
To be clear, this is not related to guest application, right? This is for public links pages? |
come-nc
reviewed
May 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
susnux
reviewed
May 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
susnux
reviewed
May 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
Jun 10, 2025
Comment on lines
+172
to
+175
| // Check that the note states the current name | ||
| // cy.get('@guestIdentificationDialog') | ||
| // .findByRole('note') | ||
| // .should('contain', 'are currently identified as Jane Doe') |
MemberAuthor
There was a problem hiding this comment.
Needs nextcloud-libraries/nextcloud-dialogs#1841
Will adjust in followup :)
skjnldsv
commented
Jun 10, 2025
MemberAuthor
Cypress tests added! 🚀 |
AndyScherzinger
approved these changes
Jun 10, 2025
skjnldsv
enabled auto-merge
June 10, 2025 22:28
susnux
previously requested changes
Jun 11, 2025
susnux
left a comment
Contributor
There was a problem hiding this comment.
Generally very nice, but has invalid DOM structure breaking WCAG / BITV.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/loading-account-menu
branch
from
June 11, 2025 14:44
0000b75 to
a6fc4aaCompareskjnldsv
commented
Jun 11, 2025
MemberAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
approved these changes
Jun 11, 2025
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
commented
Jun 11, 2025
MemberAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As a guest, it's nice to be recognised on an instance, whether you join different talk rooms, answer a form or upload files to a shared folder.
As we do so, being transparent is important, and showing the user we know who they are is mandatory.
As well as some options to clear this information.
Screenshots