Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(CalDAV): do not ignore move command object target uri - #52561
Merged
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
backportbotBot
requested review from
SebastianKrupinski, st3iny and tcitworld
as code ownersApril 30, 2025 14:28
backportbotBot
requested review from
ChristophWurst and SebastianKrupinski
and removed request for
SebastianKrupinski and tcitworldApril 30, 2025 14:28
| try { | ||
| return $this->caldavBackend->moveCalendarObject($sourceNode->getCalendarId(), (int)$this->calendarInfo['id'], $sourceNode->getId(), $sourceNode->getOwner(), $this->getOwner()); | ||
| return $this->caldavBackend->moveCalendarObject( | ||
| $sourceNode->getOwner(), |
Check notice
Code scanning / Psalm
PossiblyNullArgument
| return $this->caldavBackend->moveCalendarObject( | ||
| $sourceNode->getOwner(), | ||
| $sourceNode->getId(), | ||
| $this->getOwner(), |
Check notice
Code scanning / Psalm
PossiblyNullArgument
st3iny
approved these changes
Apr 30, 2025
SebastianKrupinski
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #52228