Uh oh!
There was an error while loading. Please reload this page.
fix(loginflow): Fix type error when password could not be decrypted - #52587
Merged
Conversation
nickvergessen
requested review from
Altahrim, artonge and provokateurin
and removed request for
a teamMay 2, 2025 11:57
nickvergessen
commented
May 2, 2025
MemberAuthor
/backport to stable31 |
nickvergessen
commented
May 2, 2025
MemberAuthor
/backport to stable30 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/fix-type-error
branch
from
May 2, 2025 12:09
9c90052 to
9009ef1Compareprovokateurin
approved these changes
May 5, 2025
come-nc
approved these changes
May 5, 2025
This was referenced May 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to be only a theoretical problem when or when breaking things intentionally in the database. But better save then sorry.
openssl_private_decryptreturns null, instead of throws, when it failed.Checklist