Skip to content

fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional - #52628

Merged
provokateurin merged 2 commits into
masterfrom
fix/files_external/hidden-password-fields
May 5, 2025
Merged

fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional#52628
provokateurin merged 2 commits into
masterfrom
fix/files_external/hidden-password-fields

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Summary

It was not possible before to make a field a password (in order to censor it in API responses) and also make it hidden so that it doesn't need to be configured in the frontend.

I hope this doesn't break anything, but at least the direction of this should be correct. In case something breaks because the value no longer exists another solution has to be found.

I also found the PHP method writeParameterInput which I first started changing until I realized it was no longer used at all and the logic was moved to the frontend without removing the dead code 🫠

Checklist

@provokateurinprovokateurin added bug 3. to review Waiting for reviews labels May 5, 2025
@provokateurinprovokateurin added this to the Nextcloud 32 milestone May 5, 2025
@provokateurin
provokateurin requested review from a team and skjnldsv as code ownersMay 5, 2025 09:10
@provokateurin
provokateurin requested review from nfebe and removed request for a teamMay 5, 2025 09:10
@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@provokateurin

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@provokateurin
provokateurinforce-pushed the fix/files_external/hidden-password-fields branch from 65f85db to 82e23daCompareMay 5, 2025 09:32
Comment threadapps/files_external/lib/Command/Backends.php Outdated
Comment threadapps/files_external/lib/Lib/DefinitionParameter.php Outdated
Comment threadapps/files_external/src/settings.js Outdated
…bining VALUE_PASSWORD and FLAG_HIDDEN
Signed-off-by: provokateurin <kate@provokateurin.de>
…ssionCredentials as hidden and optional
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurinforce-pushed the fix/files_external/hidden-password-fields branch from 82e23da to db5f6a4CompareMay 5, 2025 11:20
@provokateurinprovokateurin changed the title fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hiddenfix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optionalMay 5, 2025
@provokateurin
provokateurin requested a review from come-ncMay 5, 2025 11:20
@provokateurin
provokateurin enabled auto-merge May 5, 2025 12:23
@provokateurin
provokateurin merged commit 66c2607 into masterMay 5, 2025
@provokateurin
provokateurin deleted the fix/files_external/hidden-password-fields branch May 5, 2025 12:33
This was referenced May 5, 2025
@solracsf

Copy link
Copy Markdown
Member

Backport bot failing? 🤔

@provokateurin

Copy link
Copy Markdown
MemberAuthor

Yeah it's dead atm, but people are working on it already. If it doesn't work by tomorrow morning I will do the backports myself. I suspect this PR will have conflicts anyway, so manual work will be needed.

@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable31

@backportbot

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/52628/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 01d2a9f7 db5f6a4e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52628/stable31

Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud/server'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin

Copy link
Copy Markdown
MemberAuthor

@skjnldsv Seems like there will only be conflicts, so everything will have to be done manually.

@skjnldsv

Copy link
Copy Markdown
Member

/backport to stable31

@skjnldsv

Copy link
Copy Markdown
Member

@provokateurin testing the bot anyway :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Password is required for log-in credentials in External storage config

5 participants

@provokateurin@solracsf@skjnldsv@artonge@come-nc