Skip to content

ConfigLexicon to update lazy status - #52671

Open
ArtificialOwl wants to merge 3 commits into
masterfrom
fix/noid/lexicon-update-lazy-status
Open

ConfigLexicon to update lazy status #52671
ArtificialOwl wants to merge 3 commits into
masterfrom
fix/noid/lexicon-update-lazy-status

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented May 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Migrate a previously existing config value to right lazyness when set as lazy in Lexicon.

  • tests

@ArtificialOwl
ArtificialOwl requested a review from a team as a code ownerMay 6, 2025 23:29
@ArtificialOwl
ArtificialOwl requested review from artonge, nfebe and skjnldsv and removed request for a teamMay 6, 2025 23:29
@ArtificialOwlArtificialOwl added the 3. to review Waiting for reviews label May 6, 2025
@ArtificialOwlArtificialOwl added this to the Nextcloud 32 milestone May 6, 2025
@ArtificialOwlArtificialOwl changed the title feat(appconfig): lexicon update lazy statusConfigLexicon to update lazy status May 7, 2025
@ArtificialOwlArtificialOwl added the 2. developing Work in progress label May 7, 2025
@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/lexicon-update-lazy-status branch from 55cb1ee to 7f763faCompareMay 7, 2025 00:32
@ArtificialOwl
feat(appconfig+userconfig): lexicon update lazy status
62a82ae
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the fix/noid/lexicon-update-lazy-status branch from 7f763fa to 62a82aeCompareMay 7, 2025 15:08
@ArtificialOwlArtificialOwl removed the 2. developing Work in progress label May 7, 2025
@skjnldsv
Merge branch 'master' into fix/noid/lexicon-update-lazy-status
7fa69d2
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsvskjnldsv added the technical debt 🧱 🤔🚀 label Aug 1, 2025
skjnldsv
skjnldsv reviewed Aug 1, 2025
View reviewed changes
Comment threadtests/lib/Config/LexiconTest.php Outdated
@skjnldsv
fix: unwanted imports after rebase
910a0d3
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/noid/lexicon-update-lazy-status branch from e8d10cf to 910a0d3CompareAugust 1, 2025 11:21
@skjnldsv

skjnldsv commented Aug 1, 2025

Copy link
Copy Markdown
Member

Tried to rebase and fix tiny issues to help this move forward, but it's having some more issues it seems :)

1) Tests\lib\Config\LexiconTest::testAppConfigMigrationToLazy
TypeError: OC\AppFramework\Bootstrap\RegistrationContext::getConfigLexicon(): Return value must be of type ?OCP\Config\Lexicon\ILexicon, Tests\lib\Config\TestConfigLexicon_Migration returned
/home/runner/actions-runner/_work/server/server/lib/private/AppFramework/Bootstrap/RegistrationContext.php:1032

This was referenced Aug 22, 2025
Merged
Merged
Merged
This was referenced Sep 2, 2025
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Sep 10, 2025
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Sep 18, 2025
Merged
This was referenced Sep 25, 2025
Merged
Merged
This was referenced Jan 7, 2026
Merged
Merged
This was referenced Jan 14, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jan 22, 2026
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 33, Nextcloud 34Feb 16, 2026
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsvskjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@susnuxsusnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@artongeartongeartonge approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ArtificialOwl@skjnldsv@artonge@susnux@blizzz@nextcloud-bot