Skip to content

fix(files_external): Safely check if the timestamp is numeric - #52686

Merged
artonge merged 1 commit into
masterfrom
isNumericMtime
May 12, 2025
Merged

fix(files_external): Safely check if the timestamp is numeric#52686
artonge merged 1 commit into
masterfrom
isNumericMtime

Conversation

@solracsf

@solracsfsolracsf commented May 8, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Reduces variable assignments by directly incorporating logic into the return statement
  • Safely check if the timestamp is numeric, avoiding potential issues with invalid data

Checklist

@solracsfsolracsf added this to the Nextcloud 32 milestone May 8, 2025
@solracsfsolracsf mentioned this pull request May 8, 2025
Closed
8 tasks
@solracsf
fix(files_external): Safely check if the timestamp is numeric
2d68644
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf
solracsf marked this pull request as ready for review May 8, 2025 10:12
@solracsf
solracsf requested a review from a team as a code ownerMay 8, 2025 10:12
@solracsf
solracsf requested review from artonge, nfebe and skjnldsv and removed request for a teamMay 8, 2025 10:12
skjnldsv
skjnldsv approved these changes May 8, 2025
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane!

@artonge
artonge merged commit a2eed98 into masterMay 12, 2025
@artonge
artonge deleted the isNumericMtime branch May 12, 2025 11:21
@solracsf

solracsf commented May 12, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@solracsf

solracsf commented May 12, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@backportbotbackportbotBot mentioned this pull request May 12, 2025
Merged
@backportbotbackportbotBot mentioned this pull request May 12, 2025
Closed
2 tasks
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsfeature: external storage

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Fail to scan or access files in Swift external storage

3 participants

@solracsf@artonge@skjnldsv