Skip to content

N?A - #52692

Closed
AndyXheli wants to merge 6 commits into
nextcloud:masterfrom
AndyXheli:patch-1
Closed

N?A#52692
AndyXheli wants to merge 6 commits into
nextcloud:masterfrom
AndyXheli:patch-1

Conversation

@AndyXheli

@AndyXheliAndyXheli commented May 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@AndyXheli
Update Logging for preview generation
74db743
Since this PR was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to info Original PR
nextcloud#52300
Signed-off-by: AndyXheli <andyxheli@gmail.com>
@AndyXheli
AndyXheli requested a review from a team as a code ownerMay 8, 2025 14:38
@AndyXheli
AndyXheli requested review from Altahrim, ArtificialOwl and sorbaugh and removed request for a teamMay 8, 2025 14:38
@AndyXheliAndyXheli mentioned this pull request May 13, 2025
Closed
8 tasks
@joshtrichardsjoshtrichards linked an issue May 13, 2025 that may be closed by this pull request
[Bug]: Spamming Logs Cached preview not found for file generating a new preview. #52791
Closed
8 tasks
@joshtrichardsjoshtrichards added this to the Nextcloud 32 milestone May 13, 2025
@joshtrichards

joshtrichards commented May 13, 2025

Copy link
Copy Markdown
Member

/backport to stable31

joshtrichards
joshtrichards approved these changes May 13, 2025
View reviewed changes

@joshtrichardsjoshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info works; debug probably fine here even

@AndyXheli

AndyXheli commented May 13, 2025

Copy link
Copy Markdown
ContributorAuthor

info works; debug probably fine here even

I can update it to debug i think that would be better

@joshtrichards

joshtrichards commented May 13, 2025

Copy link
Copy Markdown
Member

@AndyXheli - Can you fix the commit message to make it in conventional format? i.e.

fix(previews): lower log level when cached preview isn't found

@AndyXheliAndyXheli changed the title Update Logging for preview generationfix(previews): lower log level when cached preview isn't foundMay 14, 2025
@AndyXheli
fix(previews): lower log level when cached preview isn't found
ae25e8f
fix(previews): lower log level when cached preview isn't found
Signed-off-by: AndyXheli <andyxheli@gmail.com>
@AndyXheli

AndyXheli commented May 14, 2025

Copy link
Copy Markdown
ContributorAuthor

@AndyXheli - Can you fix the commit message to make it in conventional format? i.e.

fix(previews): lower log level when cached preview isn't found

Should be all good now ;)

@artonge

artonge commented May 15, 2025

Copy link
Copy Markdown
Collaborator

Should be all good now ;)

You still have unconventional commit message.
Also, can you remove the merge commit?
https://github.com/nextcloud/server/pull/52692/commits

@AndyXheli
Revert "Merge branch 'master' into patch-1"
9ebe4db
This reverts commit 4bd92a4, reversing
changes made to ae25e8f.
@AndyXheliAndyXheli changed the title fix(previews): lower log level when cached preview isn't foundN?AMay 15, 2025
@github-actions

github-actionsBot commented May 23, 2025

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@AndyXheli
AndyXheli deleted the patch-1 branch May 23, 2025 02:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichardsjoshtrichardsjoshtrichards approved these changes
@artongeartongeartonge approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebe
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurstChristophWurst is a code owner
@miaulalalamiaulalalaAwaiting requested review from miaulalalamiaulalala is a code owner
@nickvergessennickvergessenAwaiting requested review from nickvergessennickvergessen is a code owner
@st3inyst3inyAwaiting requested review from st3iny
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner
@SebastianKrupinskiSebastianKrupinskiAwaiting requested review from SebastianKrupinskiSebastianKrupinski is a code owner
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner
@hamza221hamza221Awaiting requested review from hamza221hamza221 is a code owner

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbackport-requestbugfeature: loggingfeature: previews and thumbnailsfeedback-requested

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: Spamming Logs Cached preview not found for file generating a new preview.

4 participants

@AndyXheli@joshtrichards@artonge@skjnldsv