Skip to content

[stable30] fix(CalDAV): add calendar enable - #52704

Merged
SebastianKrupinski merged 1 commit into
stable30from
backport/51081/stable30
May 23, 2025
Merged

[stable30] fix(CalDAV): add calendar enable#52704
SebastianKrupinski merged 1 commit into
stable30from
backport/51081/stable30

Conversation

@backportbot

@backportbotbackportbotBot commented May 9, 2025

Copy link
Copy Markdown

Backport of #51081

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels May 9, 2025
@backportbotbackportbotBot added this to the Nextcloud 30.0.11 milestone May 9, 2025

$list = [];
foreach ($properties as $property) {
if ($property instanceof Property) {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType

Docblock-defined type OCA\DAV\Db\Property for $property is always OCA\DAV\Db\Property
@SebastianKrupinski
SebastianKrupinski marked this pull request as ready for review May 9, 2025 17:16
@skjnldsvskjnldsv mentioned this pull request May 15, 2025
@nextcloud-botnextcloud-bot mentioned this pull request May 15, 2025
20 tasks
/**
* ICalendar Interface Extension
*
* @since 32.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 32.0.0
* @since 30.0.12

/**
* Indicates whether the calendar is enabled
*
* @since 32.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 32.0.0
* @since 30.0.12

}

/**
* @since 32.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 32.0.0
* @since 30.0.12

Comment threadapps/dav/lib/CalDAV/CalendarImpl.php Outdated
}

/**
* @since 32.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 32.0.0
* @since 30.0.12

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@kesselb
kesselbforce-pushed the backport/51081/stable30 branch from cc48c5d to b7d1691CompareMay 23, 2025 08:39
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 23, 2025
@SebastianKrupinski
SebastianKrupinski merged commit 736ef9a into stable30May 23, 2025
@SebastianKrupinski
SebastianKrupinski deleted the backport/51081/stable30 branch May 23, 2025 08:57
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2025
11 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Sep 18, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 25, 2025
2 tasks
@blizzzblizzz mentioned this pull request Oct 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: caldavRelated to CalDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb@github-advanced-security@SebastianKrupinski@ChristophWurst@skjnldsv