Skip to content

feat(files_sharing): add config option for extending link-share permissions - #52777

Merged
susnux merged 3 commits into
masterfrom
feat/add-config-for-share-perm
Jul 17, 2025
Merged

feat(files_sharing): add config option for extending link-share permissions#52777
susnux merged 3 commits into
masterfrom
feat/add-config-for-share-perm

Conversation

@susnux

@susnuxsusnux commented May 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This allows the admin to control the behavior whether link shares with READ permissions should be extended to also gain SHARE permissions, allowing users (public share receivers) to add the share to their cloud.

Checklist

@susnuxsusnux added this to the Nextcloud 32 milestone May 12, 2025
@susnux
susnux requested a review from a team as a code ownerMay 12, 2025 16:43
@susnuxsusnux added the 3. to review Waiting for reviews label May 12, 2025
@susnux
susnux requested a review from a team as a code ownerMay 12, 2025 16:43
@susnux
susnux requested review from artonge, nfebe and skjnldsv and removed request for a teamMay 12, 2025 16:43
@github-project-automationgithub-project-automationBot moved this to 🏗️ In progress in 📁 Files teamMay 12, 2025
@susnuxsusnux added the pending documentation This pull request needs an associated documentation update label May 12, 2025
@susnuxsusnux self-assigned this May 12, 2025
nfebe
nfebe reviewed May 13, 2025
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php Outdated
nfebe
nfebe reviewed May 13, 2025
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the config to the config lexicon, so that occ is aware of the configuration via config list : https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Config/ConfigLexicon.php

@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch from 539f283 to f32b6d6CompareMay 27, 2025 10:19
@susnux
susnux requested a review from nfebeMay 27, 2025 10:19
artonge
artonge reviewed May 27, 2025
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php Outdated
@susnux
susnux requested a review from artongeMay 27, 2025 12:41
@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch 3 times, most recently from 7d1af02 to 23e22c3CompareMay 28, 2025 09:59
@susnuxsusnux added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 28, 2025
skjnldsv
skjnldsv previously approved these changes May 29, 2025
View reviewed changes
@skjnldsv
skjnldsv dismissed their stale reviewMay 29, 2025 04:22

Waiting for "to review"

@skjnldsv
skjnldsv self-requested a review May 29, 2025 04:22
@susnux

This comment was marked as outdated.

Sign in to view
@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch from 23e22c3 to 4201a71CompareJune 2, 2025 15:05
@susnuxsusnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 2, 2025
@susnux

susnux commented Jun 2, 2025

Copy link
Copy Markdown
ContributorAuthor

Waiting for "to review"

Done

@susnux

susnux commented Jun 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/compile

@nextcloud-command
nextcloud-command requested a review from a team as a code ownerJune 2, 2025 15:42
@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch from 0f3de05 to 35c165eCompareJune 19, 2025 11:57
@susnux

susnux commented Jun 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/compile

come-nc
come-nc reviewed Jun 19, 2025
View reviewed changes
Comment threadapps/settings/lib/Settings/Admin/Sharing.php Outdated
come-nc
come-nc approved these changes Jun 19, 2025
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a use for ConfigLexicon I think, but otherwise good 👍

@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch from c0161e9 to 17fa3fcCompareJune 19, 2025 14:25
@susnux

susnux commented Jun 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Missing a use for ConfigLexicon I think, but otherwise good 👍

yes fixed while rebasing

ArtificialOwl
ArtificialOwl reviewed Jun 19, 2025
View reviewed changes
Comment threadcore/AppInfo/ConfigLexicon.php Outdated
Comment threadapps/settings/lib/Settings/Admin/Sharing.php Outdated
@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch 4 times, most recently from 67f612b to 42a71c7CompareJuly 17, 2025 13:10
susnuxand others added 3 commits July 17, 2025 16:59
@susnux
feat(files_sharing): add config option for extending link-share permi…
a18e61a
…ssions
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(Coordinator): ensure the core app is loaded first
7fe272f
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command@susnux
chore(assets): Recompile assets
1eb6f0b
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the feat/add-config-for-share-perm branch from 42a71c7 to 1eb6f0bCompareJuly 17, 2025 14:59
@susnux
susnux merged commit ebc5ae8 into masterJul 17, 2025
210 of 214 checks passed
@susnux
susnux deleted the feat/add-config-for-share-perm branch July 17, 2025 15:58
@ArtificialOwlArtificialOwl mentioned this pull request Jul 23, 2025
Closed
@susnuxsusnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files teamAug 11, 2025
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwlArtificialOwlArtificialOwl left review comments
@come-nccome-nccome-nc approved these changes
@artongeartongeartonge approved these changes
@nfebenfebeAwaiting requested review from nfebe
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

@susnuxsusnux

Labels

3. to reviewWaiting for reviewsenhancementfeature: sharingpending documentationThis pull request needs an associated documentation update

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

8 participants

@susnux@ArtificialOwl@artonge@nfebe@skjnldsv@come-nc@tobiasKaminsky@nextcloud-command