Skip to content

feat(log): Log the request id sent with the request - #52782

Merged
provokateurin merged 2 commits into
masterfrom
feat/log-client-side-req-id
May 14, 2025
Merged

feat(log): Log the request id sent with the request#52782
provokateurin merged 2 commits into
masterfrom
feat/log-client-side-req-id

Conversation

@come-nc

@come-nccome-nc commented May 13, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

This should help matching client logs with server logs, hopefully.

Checklist

@come-nccome-nc added this to the Nextcloud 32 milestone May 13, 2025
@come-nc
come-nc requested a review from nilsdingMay 13, 2025 09:08
@come-nccome-nc self-assigned this May 13, 2025
@come-nccome-nc added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 13, 2025
@come-nc
come-nc marked this pull request as ready for review May 13, 2025 09:19
@come-nc
come-nc requested a review from a team as a code ownerMay 13, 2025 09:19
@come-nc
come-nc requested review from Altahrim, artonge, icewind1991, mgallien and sorbaugh and removed request for a teamMay 13, 2025 09:19
nilsding
nilsding approved these changes May 13, 2025
View reviewed changes

@nilsdingnilsding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm, thanks :)

provokateurin
provokateurin approved these changes May 13, 2025
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@provokateurin

provokateurin commented May 13, 2025

Copy link
Copy Markdown
Member

/backport to stable31

@provokateurin

provokateurin commented May 13, 2025

Copy link
Copy Markdown
Member

/backport to stable30

come-nc added 2 commits May 14, 2025 00:35
@come-nc
feat(log): Log the request id sent with the request
4c25654
This should help matching client logs with server logs, hopefully.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(log): Only log client request id if present, and at the end
2b4bfcc
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the feat/log-client-side-req-id branch from 6d8d232 to 2b4bfccCompareMay 13, 2025 22:35
@provokateurin
provokateurin merged commit 0f03a89 into masterMay 14, 2025
@provokateurin
provokateurin deleted the feat/log-client-side-req-id branch May 14, 2025 08:07
This was referenced May 14, 2025
Merged
Merged
@joshtrichardsjoshtrichards mentioned this pull request Jun 25, 2025
Open
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@nilsdingnilsdingnilsding approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@mgallienmgallienAwaiting requested review from mgallien
@artongeartongeAwaiting requested review from artonge

Assignees

@come-nccome-nc

Labels

3. to reviewWaiting for reviewsfeature: logging

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@come-nc@provokateurin@icewind1991@nilsding@joshtrichards@skjnldsv