Skip to content

[stable30] feat: add command to check files_external dependencies - #52784

Merged
icewind1991 merged 2 commits into
stable30from
backport/52681/stable30
May 15, 2025
Merged

[stable30] feat: add command to check files_external dependencies#52784
icewind1991 merged 2 commits into
stable30from
backport/52681/stable30

Conversation

@backportbot

@backportbotbackportbotBot commented May 13, 2025

Copy link
Copy Markdown

Backport of #52681

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added the 3. to review Waiting for reviews label May 13, 2025
@backportbotbackportbotBot added this to the Nextcloud 30.0.11 milestone May 13, 2025
@icewind1991
icewind1991force-pushed the backport/52681/stable30 branch from bb9115a to d4ca6dcCompareMay 13, 2025 09:20
@icewind1991
icewind1991 marked this pull request as ready for review May 13, 2025 09:22
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the backport/52681/stable30 branch from d4ca6dc to 85f2161CompareMay 13, 2025 09:25
$anyMissing = true;
$output->writeln($backend->getText() . ':');
foreach ($missingDependencies as $missingDependency) {
if ($missingDependency->getMessage()) {

Check notice

Code scanning / Psalm

RiskyTruthyFalsyComparison

Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.
Comment threadapps/files_external/lib/Lib/Backend/SMB.php Fixed
@icewind1991

Copy link
Copy Markdown
Member

Added #48421

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the backport/52681/stable30 branch from 7a9d210 to ae4b127CompareMay 13, 2025 12:08
@skjnldsvskjnldsv mentioned this pull request May 15, 2025
@nextcloud-botnextcloud-bot mentioned this pull request May 15, 2025
20 tasks
@icewind1991
icewind1991 merged commit cc56c3b into stable30May 15, 2025
@icewind1991
icewind1991 deleted the backport/52681/stable30 branch May 15, 2025 12:09
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2025
11 tasks
@nextcloud-botnextcloud-bot mentioned this pull request Sep 18, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Sep 25, 2025
2 tasks
@blizzzblizzz mentioned this pull request Oct 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@artonge@github-advanced-security