Skip to content

fix: do not crash the event emitting parent process if on listener fails - #52797

Closed
SebastianKrupinski wants to merge 0 commit into
masterfrom
fix/noid-catch-listener-erros-instead-of-failing
Closed

fix: do not crash the event emitting parent process if on listener fails#52797
SebastianKrupinski wants to merge 0 commit into
masterfrom
fix/noid-catch-listener-erros-instead-of-failing

Conversation

@SebastianKrupinski

Copy link
Copy Markdown
Contributor
  • Resolves:

  • Constructor Errors
    TypeError: OCA\Talk\Listener\CalDavEventListener::__construct(): Argument Add a thumbnail/grid view to the Files app #6 ($userId) must be of type string, null given
    #26 /spreed/lib/Listener/CalDavEventListener.php(32): OCA\Talk\Listener\CalDavEventListener::__construct

  • Execution Errors
    ErrorException: Warning: Attempt to read property "LOCATION" on null
    Add drone.io support #17 /spreed/lib/Listener/CalDavEventListener.php(68): OCA\Talk\Listener\CalDavEventListener::handle

Summary

  • Overrides the Symfony dispatcher call listener function to catch and log errors with event listeners without crashing the entire parent process

Checklist

@SebastianKrupinskiSebastianKrupinski self-assigned this May 13, 2025
@SebastianKrupinskiSebastianKrupinski added the 2. developing Work in progress label May 13, 2025
@SebastianKrupinski
SebastianKrupinskiforce-pushed the fix/noid-catch-listener-erros-instead-of-failing branch from b1d6814 to f8744c9CompareMay 13, 2025 16:30
@SebastianKrupinskiSebastianKrupinski changed the title pref: improve caledar object query performance and accuracyfix: do not crash the event emitting parent process if on listener failsMay 13, 2025
@SebastianKrupinski
SebastianKrupinskiforce-pushed the fix/noid-catch-listener-erros-instead-of-failing branch from f8744c9 to 0eb530eCompareMay 13, 2025 16:34
@github-project-automationgithub-project-automationBot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware teamMay 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant

@SebastianKrupinski