Uh oh!
There was an error while loading. Please reload this page.
[stable31] Introduce own method for calendar unsharing - #52808
Merged
Conversation
backportbotBot
requested review from
ChristophWurst, SebastianKrupinski, kesselb and st3inyMay 14, 2025 09:04
kesselbforce-pushed
the
backport/52046/stable31
branch
from
May 15, 2025 09:07
91157d5 to
17cb524Comparekesselb
commented
May 15, 2025
Contributor
New commands and sorting caused conflicts in info.xml. |
kesselbforce-pushed
the
backport/52046/stable31
branch
from
May 15, 2025 10:06
17cb524 to
510452eComparekesselb
marked this pull request as ready for review
May 15, 2025 10:14
kesselb
approved these changes
May 15, 2025
kesselbforce-pushed
the
backport/52046/stable31
branch
from
May 16, 2025 10:47
510452e to
b1a0f82Compare- Introduces a `unshare` method in `CalDavBackend` to handle user unshares. - Implements check to determine if unshare entry is needed based on group/circle membership. - Ensures `updateShares` is only used when the calendar owner manages shares. - Resolves issue where unsharing a calendar as owner created an unshare entry in `oc_dav_shares`. Related PRs: - #43117 - #47737 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Before: Find all entries in `dav_shares` with `access = 5` for the user's principal, as well as group and circle memberships. After: Find all entries in `dav_shares` with `access = 5` solely for the user's principal. Future support for unsharing group or circle principals could be considered as a feature enhancement. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
backport/52046/stable31
branch
from
May 19, 2025 12:35
b1a0f82 to
1313fdaCompareChristophWurst
approved these changes
May 19, 2025
kesselb
commented
May 19, 2025
Contributor
/backport to stable30 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52046
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.