Uh oh!
There was an error while loading. Please reload this page.
fix(files): do not even try to fetch a preview if has-preview is false - #52809
Conversation
skjnldsv
commented
May 14, 2025
/backport to stable31 |
skjnldsv
commented
May 14, 2025
/backport to stable30 |
has-preview is false
susnux
left a comment
There was a problem hiding this comment.
I do not really expect performance improvements as mimeFallback on the preview endpoint should also check this so so we already would get the mime type icon.
Also one thing to consider is that doing this will stop the browser from caching the mime icon as the preview, so other apps might need to do this as well otherwise we do not save anything 😔
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
commented
May 14, 2025
This created issues, for some reason I got many img loading errors after this PR. |
skjnldsv
commented
May 14, 2025
This removes one request :) |
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
May 14, 2025
fixed |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Prevent one additional request in case the backend said there was no preview.
This property does NOT mean the preview was not generated, but it actually means we CANNOT generate it (disabled or no preview available)
Good suggestion by @icewind1991 !