Uh oh!
There was an error while loading. Please reload this page.
Add command to clear dav's photo cache - #52879
Merged
Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
bug/noid/clear-dav-photo-cache
branch
from
May 15, 2025 16:28
f367139 to
3d1de79Comparekesselb
marked this pull request as ready for review
May 15, 2025 16:46
kesselb
requested review from
a team, SebastianKrupinski and hamza221
as code ownersMay 15, 2025 16:46
kesselb
requested review from
Altahrim, ArtificialOwl and sorbaugh
and removed request for
a teamMay 15, 2025 16:46
ChristophWurst
approved these changes
May 15, 2025
kesselb
commented
May 20, 2025
ContributorAuthor
/backport 8a1ae09 to stable31 |
2 tasks
kesselb
commented
May 20, 2025
ContributorAuthor
/backport 8a1ae09 to stable30 |
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contacts is using a request like below to fetch the photo for a user from the vcard.
/remote.php/dav/addressbooks/users/alice/z-server-generated--system/Database:jane.vcf?photoAs fetching and parsing vcards might be expensive there's a cache for the photos in app-data. While there are event listeners in place to reset the cache for a vcard on update or delete, there might be still cases where it's helpful to clear the cache.
How to test:
'%dav-photocache%''%dav-photocache%''%dav-photocache%'Backports:
Only the command, refactoring is for 32.
Checklist