Uh oh!
There was an error while loading. Please reload this page.
Replace "remove" wording with "delete" - #52897
Conversation
susnux
commented
May 16, 2025
3a9cc8f to
b91571dCompareb91571d to
0bec33dComparesusnux
commented
May 16, 2025
- Replace "remove" wording with "delete"- npm run build+ refactor(settings): replace "remove" wording with "delete"+ chore: recompile assets |
0bec33d to
8e5d017CompareJerome-Herbinet
commented
May 19, 2025
I'll take a look at it later this week @susnux |
skjnldsv
commented
May 21, 2025
@Jerome-Herbinet also cypress tests needs adjusting Search for the old strings in the cypress tests folder |
8e5d017 to
483ae9aCompareJerome-Herbinet
commented
May 22, 2025
894ee3e to
3700429CompareJerome-Herbinet
commented
May 22, 2025
@susnux it's OK, I updated the branch and changed commits' names. Is the cypress issue fixed ? |
skjnldsv
commented
May 22, 2025
You need to do it |
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
dd46843 to
54a58c0CompareJerome-Herbinet
commented
May 23, 2025
@susnux I replaced "Remove group" with "Delete group" in Cypress ; hope that it will all work. |
zak39
commented
May 23, 2025
Hi everyone :) Cypress tests have failed again. |
skjnldsv
commented
May 24, 2025
this time it looks like it crashed aha, bad luck :) |
skjnldsv
commented
May 24, 2025
skjnldsv
commented
May 24, 2025
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |

This is more direct and understandable.
"Remove" may suggest that the group will remain somewhere, whereas "Delete" leaves no doubt.
Next, the popup message specifies that users will not be deleted.
Summary
TODO
Checklist