chore: Remove useless legacy autoloader for tests

[come-nc]

Summary

We do not need the legacy autoloader for the TestCase, because we have PSR-4 loading added in 54250ed

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

This breaks apps

[come-nc]

This breaks apps

I expected apps were using tests/bootstrap.php, but it seems a lot have their own.

They should be updated to use:

\OC::$composerAutoloader->addPsr4('Test\\', OC::$SERVERROOT . '/tests/lib/', true);
\OC::$composerAutoloader->addPsr4('Tests\\', OC::$SERVERROOT . '/tests/', true);

As is done is server bootstrap.php.

That is still not that pretty as it depends upon \OC::$composerAutoloader which should not be public API.
Not sure what a pretty solution would be?
Maybe we add an autoload.php in tests/ that application can require?

[come-nc]

I extracted the autoload.php into #52951

• chore: Add an autoload.php file for tests relying on core class #52951
• chore(tests): Cleanup bootstrap.php to be forward-compatible notifications#2352
• chore(tests): Cleanup bootstrap.php to be forward-compatible photos#3029
• chore(tests): Cleanup bootstrap.php to be forward-compatible data_request#376
• chore(tests): Cleanup bootstrap.php to be forward-compatible firstrunwizard#1620
• chore(tests): Cleanup bootstrap.php to be forward-compatible contacts#4475
• chore(tests): Cleanup bootstrap.php to be forward-compatible activity#2022
• chore(tests): Cleanup bootstrap.php to be forward-compatible maps#1418
• chore(tests): Cleanup bootstrap.php to be forward-compatible files_pdfviewer#1214
• chore(tests): Cleanup bootstrap.php to be forward-compatible limit_login_to_ip#106
• chore(tests): Cleanup bootstrap.php to be forward-compatible ldap_contacts_backend#292
• chore(tests): Cleanup bootstrap.php to be forward-compatible privacy#1175
• chore(tests): Cleanup bootstrap.php to be forward-compatible tables#1806
• chore(tests): Cleanup bootstrap.php to be forward-compatible user_oidc#1122
• chore(tests): Cleanup bootstrap.php to be forward-compatible terms_of_service#1074
• chore(tests): Cleanup bootstrap.php to be forward-compatible spreed#15152
• chore(tests): Cleanup bootstrap.php to be forward-compatible user_saml#961
• Merge this one 🎉

[skjnldsv]

Once apps are handled: 👌

[nickvergessen]

What about all the community apps?
https://github.com/search?q=org%3Anextcloud%20addValidRoot&type=code

[skjnldsv]

What about all the community apps? github.com/search?q=org%3Anextcloud%20addValidRoot&type=code

communicate as breaking and move on ?

[come-nc]

@nickvergessen Can we merge now?
There is a workaround with tests/bootstrap.php and most apps migrated to it.