Skip to content

[stable12] urldecode group principals in Cal- and CardDAV backend - #5299

Merged
MorrisJobke merged 1 commit into
stable12from
bugfix-stable12/4885/calendar_shares_url_special_char_issue
Jun 15, 2017
Merged

[stable12] urldecode group principals in Cal- and CardDAV backend#5299
MorrisJobke merged 1 commit into
stable12from
bugfix-stable12/4885/calendar_shares_url_special_char_issue

Conversation

@georgehrke

Copy link
Copy Markdown
Member

backport of #5298
fixes#4885

@georgehrkegeorgehrke added the 3. to review Waiting for reviews label Jun 8, 2017
@georgehrkegeorgehrke added this to the Nextcloud 12.0.1 milestone Jun 8, 2017
@georgehrke
georgehrke requested a review from rullzerJune 8, 2017 07:12
@mention-bot

Copy link
Copy Markdown

@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @tcitworld and @schiessle to be potential reviewers.

@georgehrkegeorgehrke changed the title urldecode group principals in Cal- and CardDAV backend[stable12] urldecode group principals in Cal- and CardDAV backendJun 8, 2017
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
georgehrkeforce-pushed the bugfix-stable12/4885/calendar_shares_url_special_char_issue branch from 0679f60 to dba4935CompareJune 12, 2017 19:02
@codecov

codecovBot commented Jun 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #5299 into stable12 will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable12 #5299 +/- ##
==============================================
+ Coverage 54.18% 54.18% +<.01% 
Complexity 22296 22296 ==============================================
Files 1380 1380 Lines 85347 85351 +4 Branches 1322 1322 ==============================================
+ Hits 46244 46247 +3 - Misses 39103 39104 +1
Impacted FilesCoverage ΔComplexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php86.03% <100%> (+0.02%)218 <0> (ø)⬇️
apps/dav/lib/CardDAV/CardDavBackend.php85.74% <100%> (+0.06%)88 <0> (ø)⬇️
apps/comments/lib/EventHandler.php79.16% <0%> (-8.34%)7% <0%> (ø)
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@georgehrke@mention-bot@nickvergessen@MorrisJobke