Skip to content

[stable31] feat(files_trashbin): Refactor expire background job to support parallel run - #53026

Merged
artonge merged 2 commits into
stable31from
backport/52825/stable31
Sep 15, 2025
Merged

[stable31] feat(files_trashbin): Refactor expire background job to support parallel run#53026
artonge merged 2 commits into
stable31from
backport/52825/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented May 21, 2025

Copy link
Copy Markdown

Backport of #52825

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbotBot requested a review from artongeMay 21, 2025 08:06
@backportbotbackportbotBot added enhancement 3. to review Waiting for reviews feature: trashbin php Pull requests that update Php code labels May 21, 2025
@backportbotbackportbotBot added this to the Nextcloud 31.0.6 milestone May 21, 2025
@artonge
artongeforce-pushed the backport/52825/stable31 branch from dfd492b to 81de5afCompareMay 21, 2025 08:20
@artonge
artonge marked this pull request as ready for review May 21, 2025 08:21
@backportbot
backportbotBotforce-pushed the backport/52825/stable31 branch from 81de5af to 6e4c5d5CompareMay 21, 2025 09:30
@artonge
artongeforce-pushed the backport/52825/stable31 branch 2 times, most recently from 3a65d5a to a58b3e9CompareMay 21, 2025 09:42
@artonge
artonge marked this pull request as draft May 22, 2025 08:26

@AndyScherzingerAndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge
artonge marked this pull request as ready for review June 4, 2025 12:36
@artonge
artonge marked this pull request as draft June 4, 2025 12:36
@skjnldsvskjnldsv added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Aug 19, 2025
@AndyScherzinger

Copy link
Copy Markdown
Member

@artonge merge?

@artonge
artonge marked this pull request as ready for review August 28, 2025 08:06
@artonge
artongeforce-pushed the backport/52825/stable31 branch 3 times, most recently from 69b7391 to cd90ee4CompareAugust 28, 2025 08:17
@artonge
artonge marked this pull request as draft August 28, 2025 15:45
@backportbot
backportbotBotforce-pushed the backport/52825/stable31 branch from cd90ee4 to c69e5d9CompareSeptember 9, 2025 08:27
@artonge
artongeforce-pushed the backport/52825/stable31 branch from c69e5d9 to c069007CompareSeptember 9, 2025 14:19
@artonge
artonge marked this pull request as ready for review September 9, 2025 14:21
@nextcloud-botnextcloud-bot mentioned this pull request Sep 10, 2025
17 tasks
@artonge
artongeforce-pushed the backport/52825/stable31 branch from c069007 to 7d1cdfeCompareSeptember 11, 2025 09:53
Signed-off-by: Louis Chemineau <louis@chmn.me>
…lel run
- Follow-up of #51600
The original PR introduced the possibility to continue an `ExpireTrash` job by saving the offset. This was to prevent having to start over the whole user list when the job crashed or was killed.
But on big instances, one process is not enough to go through all the users in a timely manner. Supporting parallel run allows covering more ground faster.
This PR introduced this possibility. We are now storing the offset right away to allow another parallel job to pick up the task at that point. We are arbitrarily cutting the user list in chunk of 10 to not drastically overflow the 30 minutes time limit.
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
artongeforce-pushed the backport/52825/stable31 branch from 7d1cdfe to 60455d7CompareSeptember 11, 2025 14:10
@artonge
artonge merged commit a9daf61 into stable31Sep 15, 2025
201 of 212 checks passed
@artonge
artonge deleted the backport/52825/stable31 branch September 15, 2025 07:51
@blizzzblizzz mentioned this pull request Oct 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancementfeature: trashbinphpPull requests that update Php code♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger@artonge@Altahrim@skjnldsv