Uh oh!
There was an error while loading. Please reload this page.
fix(files_sharing): show note, label and list of uploaded files on file drop - #53055
Conversation
susnux
commented
May 22, 2025
/backport to master |
5235cfc to
5a6d0dfComparekousu
commented
May 25, 2025
Wow! Thank you for fixing that so quickly @susnux 😃 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lewis8265
commented
May 25, 2025
I was just here to enquire about the lack of uploaded file feeback and that the message function wasn't working. Thank for your contribution :) |
szaimen
left a comment
There was a problem hiding this comment.
Tested and works. Also looks good from the screenshots but did not review the code.
Thanks for fixing this! :)
szaimen
commented
May 26, 2025
@susnux is there a reason why you did not target master directly? |
susnux
commented
May 26, 2025
No, I tried reproducing and fixing this for a ticket on 31 and only later noticed its bigger than expected so directly pushing it to 31 is easier and afterwards adjust for master. |
f226ad3 to
971c083Comparesusnux
commented
May 26, 2025
/compile |
provokateurin
left a comment
There was a problem hiding this comment.
Code LGTM, but did not test
97fae34 to
c0060f8Compare…le drop This was missing from the Vue migration of the public share view: - Show the note as the description of the file drop - Show the label as the heading of the file drop if available - Show list of uploaded files for verification Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
c0060f8 to
c3e9c89Compare
Summary
This was missing from the Vue migration of the public share view:
Checklist