Skip to content

fix(files_sharing): show note, label and list of uploaded files on file drop - #53055

Merged
AndyScherzinger merged 2 commits into
stable31from
fix/upload-file-drop-info
May 26, 2025
Merged

fix(files_sharing): show note, label and list of uploaded files on file drop#53055
AndyScherzinger merged 2 commits into
stable31from
fix/upload-file-drop-info

Conversation

@susnux

@susnuxsusnux commented May 22, 2025

Copy link
Copy Markdown
Contributor

Summary

This was missing from the Vue migration of the public share view:

  • Show the note as the description of the file drop
  • Show the label as the heading of the file drop if available
  • Show list of uploaded files for verification

Screenshot 2025-05-22 at 17-01-20 File drop - Nextcloud

Checklist

@susnuxsusnux added this to the Nextcloud 31.0.6 milestone May 22, 2025
@susnux
susnux requested review from a team, nfebe, skjnldsv and szaimen and removed request for a teamMay 22, 2025 15:06
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to master

@susnux
susnux requested a review from artongeMay 22, 2025 15:07
@susnux
susnuxforce-pushed the fix/upload-file-drop-info branch from 5235cfc to 5a6d0dfCompareMay 22, 2025 15:09
@kousu

Copy link
Copy Markdown

Wow! Thank you for fixing that so quickly @susnux 😃

Comment threadapps/files_sharing/src/views/FilesViewFileDropEmptyContent.vue Outdated
Comment threadapps/files_sharing/src/views/FilesViewFileDropEmptyContent.vue Outdated
@susnux
susnux requested a review from skjnldsvMay 25, 2025 18:54
@Lewis8265

Copy link
Copy Markdown

I was just here to enquire about the lack of uploaded file feeback and that the message function wasn't working. Thank for your contribution :)

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Also looks good from the screenshots but did not review the code.

Thanks for fixing this! :)

@szaimen

Copy link
Copy Markdown
Contributor

/backport to master

@susnux is there a reason why you did not target master directly?

@susnux

Copy link
Copy Markdown
ContributorAuthor

is there a reason why you did not target master directly?

No, I tried reproducing and fixing this for a ticket on 31 and only later noticed its bigger than expected so directly pushing it to 31 is easier and afterwards adjust for master.

@susnux
susnuxforce-pushed the fix/upload-file-drop-info branch from f226ad3 to 971c083CompareMay 26, 2025 09:38
@susnux

Copy link
Copy Markdown
ContributorAuthor

/compile

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but did not test

@susnux
susnuxforce-pushed the fix/upload-file-drop-info branch 2 times, most recently from 97fae34 to c0060f8CompareMay 26, 2025 10:42
susnuxand others added 2 commits May 26, 2025 14:14
…le drop
This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnuxforce-pushed the fix/upload-file-drop-info branch from c0060f8 to c3e9c89CompareMay 26, 2025 12:14
@AndyScherzinger
AndyScherzinger merged commit 30018bf into stable31May 26, 2025
@AndyScherzinger
AndyScherzinger deleted the fix/upload-file-drop-info branch May 26, 2025 12:54
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2025
10 tasks
@susnuxsusnux mentioned this pull request Jun 6, 2025
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@susnux@kousu@Lewis8265@szaimen@AndyScherzinger@skjnldsv@provokateurin@nextcloud-command