Skip to content

perf(base): Stop setting up the FS for every basic auth request - #53141

Merged
skjnldsv merged 7 commits into
masterfrom
perf/files/setup-fs-basic-auth-request
Jul 11, 2025
Merged

perf(base): Stop setting up the FS for every basic auth request#53141
skjnldsv merged 7 commits into
masterfrom
perf/files/setup-fs-basic-auth-request

Conversation

@provokateurin

@provokateurinprovokateurin commented May 27, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Summary

An alternative approach to #52980 as it seems all the code is just dead (let's see what CI says). Probably quite similar to #36589, but I tried to remove as little as possible (so further cleanups would be needed).

Checklist

@provokateurinprovokateurin added this to the Nextcloud 32 milestone May 27, 2025
@provokateurinprovokateurin mentioned this pull request May 27, 2025
Closed
4 tasks
@provokateurin
provokateurinforce-pushed the perf/files/setup-fs-basic-auth-request branch 2 times, most recently from 63a9c61 to 0551675CompareMay 27, 2025 13:55
@provokateurinprovokateurin changed the title fix(dav): Initialize the FS for the user right after authenticatingperf(base): Stop setting up the FS for every basic auth requestJun 2, 2025
@provokateurin
provokateurinforce-pushed the perf/files/setup-fs-basic-auth-request branch from 0551675 to 9326548CompareJune 2, 2025 12:01
@provokateurinprovokateurin added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 2, 2025
@provokateurin
provokateurin marked this pull request as ready for review June 2, 2025 12:01
@provokateurin
provokateurin requested a review from a team as a code ownerJune 2, 2025 12:01
@provokateurin
provokateurin requested review from Altahrim, juliusknorr, leftybournes, miaulalala, nickvergessen and yemkareems and removed request for a teamJune 2, 2025 12:01
@provokateurin

provokateurin commented Jun 2, 2025

Copy link
Copy Markdown
MemberAuthor

Requesting review from the people who did the previous attempts, just to be sure there is nothing wrong...

come-nc
come-nc reviewed Jun 2, 2025
View reviewed changes
Comment threadlib/private/Server.php
@provokateurin

provokateurin commented Jun 2, 2025

Copy link
Copy Markdown
MemberAuthor

The AvatarController is abusing the cache as it relies on the data being present. Cached data can be removed at any point, so not having a cache must also work (the integration tests don't).

@provokateurin
provokateurinforce-pushed the perf/files/setup-fs-basic-auth-request branch from 9326548 to 32c331aCompareJune 2, 2025 13:44
@nickvergessen

nickvergessen commented Jun 4, 2025

Copy link
Copy Markdown
Member

The AvatarController is abusing the cache as it relies on the data being present. Cached data can be removed at any point, so not having a cache must also work (the integration tests don't).

Which worked before with the file cache as it was simply written to disk.
Could be migrated to appdata / ISimpleFile in the meantime.

@provokateurin
provokateurinforce-pushed the perf/files/setup-fs-basic-auth-request branch from 32c331a to d92e5e2CompareJuly 1, 2025 09:12
@provokateurin
provokateurin requested a review from a team as a code ownerJuly 1, 2025 09:12
@provokateurin
provokateurin requested review from susnux and removed request for a teamJuly 1, 2025 09:12
@provokateurin
provokateurinforce-pushed the perf/files/setup-fs-basic-auth-request branch from d92e5e2 to a324c76CompareJuly 1, 2025 10:53
@provokateurin

provokateurin commented Jul 1, 2025

Copy link
Copy Markdown
MemberAuthor

/compile

@nextcloud-command
nextcloud-command requested a review from a team as a code ownerJuly 1, 2025 11:06
provokateurinand others added 7 commits July 8, 2025 11:38
@provokateurin
fix(dav): Initialize the FS for the user right after authenticating
689a853
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
perf(base): Stop setting up the FS for every basic auth request
0eae0e3
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
fix(core): Stop abusing the cache for avatar upload
24f7a2e
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
refactor(Server): Deprecate \OCP\ICache service and replace it with a…
57191d4
… distributed cache
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
chore: Remove unused \OC\Cache\File
0d8f983
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
chore: Remove unused \OC\Cache\CappedMemoryCache
9070552
Signed-off-by: provokateurin <kate@provokateurin.de>
@nextcloud-command@provokateurin
chore(assets): Recompile assets
caddc8d
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@provokateurin
provokateurinforce-pushed the perf/files/setup-fs-basic-auth-request branch from 017eeb4 to caddc8dCompareJuly 8, 2025 09:43
@skjnldsv
skjnldsv merged commit 6f0255d into masterJul 11, 2025
221 of 243 checks passed
@skjnldsv
skjnldsv deleted the perf/files/setup-fs-basic-auth-request branch July 11, 2025 13:25
@provokateurin

provokateurin commented Jul 11, 2025

Copy link
Copy Markdown
MemberAuthor

@skjnldsv I'm not sure if the CI failure was related, so we might have always red master now...

@skjnldsv

skjnldsv commented Jul 11, 2025

Copy link
Copy Markdown
Member

@skjnldsv I'm not sure if the CI failure was related, so we might have always red master now...

I'll have a look 👍

@nickvergessen

nickvergessen commented Jul 11, 2025

Copy link
Copy Markdown
Member

Yeah sounds like it broke all external storages :/

@skjnldsv

skjnldsv commented Jul 11, 2025

Copy link
Copy Markdown
Member

Dammit 😢
The merge button was green

@skjnldsv

skjnldsv commented Jul 11, 2025

Copy link
Copy Markdown
Member

So, revert ?

@provokateurin

provokateurin commented Jul 11, 2025

Copy link
Copy Markdown
MemberAuthor

For me it was red 🤔 Yeah please revert :/

This was referenced Jul 11, 2025
Merged
Merged
@skjnldsv

skjnldsv commented Jul 11, 2025

Copy link
Copy Markdown
Member

#53920

@provokateurin

provokateurin commented Jul 11, 2025

Copy link
Copy Markdown
MemberAuthor

@skjnldsv Why did you only revert one commit?

@nickvergessen

nickvergessen commented Jul 11, 2025

Copy link
Copy Markdown
Member

Because GitHub always only reverts the merge commit

@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@come-nccome-nccome-nc approved these changes
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@miaulalalamiaulalalaAwaiting requested review from miaulalala
@susnuxsusnuxAwaiting requested review from susnuxsusnux is a code owner automatically assigned from nextcloud/server-frontend
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Basic auth requests always set up the filesystem

6 participants

@provokateurin@nickvergessen@skjnldsv@juliusknorr@come-nc@nextcloud-command