Uh oh!
There was an error while loading. Please reload this page.
[stable30] fix(files): do nothing if view local dialog was just closed - #53176
Merged
Conversation
susnuxforce-pushed
the
backport/53171/stable30
branch
from
May 31, 2025 17:08
0ec4ea5 to
54d4b25Comparesusnux
approved these changes
May 31, 2025
susnux
marked this pull request as ready for review
May 31, 2025 17:08
AndyScherzingerforce-pushed
the
backport/53171/stable30
branch
from
June 1, 2025 11:46
54d4b25 to
a799981CompareAndyScherzinger
enabled auto-merge
June 1, 2025 11:46
AndyScherzingerforce-pushed
the
backport/53171/stable30
branch
2 times, most recently
from
June 1, 2025 17:25
a6f23e1 to
233646cCompareAndyScherzinger
commented
Jun 1, 2025
Member
/compile |
AndyScherzinger
approved these changes
Jun 1, 2025
AndyScherzinger
commented
Jun 1, 2025
Member
@susnux tests failure seems related https://github.com/nextcloud/server/actions/runs/15377636518/job/43264640419?pr=53176 |
susnuxforce-pushed
the
backport/53171/stable30
branch
from
June 2, 2025 14:27
8bed54e to
072c0aaComparesusnux
commented
Jun 2, 2025
Contributor
@AndyScherzinger should be fixed now, problem is that stable30 still uses Jest so the test needs to be slightly different from Vitest |
We try to open a file in the Nextcloud client. If this fails a dialog is shown with 3 options: 1. Retry: If it fails no further dialog is shown. 2. Open online: The viewer is used to open the file. 3. Close the dialog and nothing happens (abort). This correctly implements 3 and also adds some comments + order file in reading order (using `function` instead of arrow functions allows this easily). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
susnuxforce-pushed
the
backport/53171/stable30
branch
from
June 2, 2025 14:56
072c0aa to
ed99adbCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53171
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.