Skip to content

fix(profile): do not restore previous value on invalid request - #53178

Merged
skjnldsv merged 3 commits into
masterfrom
fix/reset-property
Jun 1, 2025
Merged

fix(profile): do not restore previous value on invalid request#53178
skjnldsv merged 3 commits into
masterfrom
fix/reset-property

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

When entering a value that is valid on the front, but not on the back, the current input value gets reset.
It makes it annoying if you're typing a phone number and it gets sent to the backend before you're done.

Peek.29-05-2025.11-13.mp4

@skjnldsvskjnldsv added this to the Nextcloud 32 milestone May 29, 2025
@skjnldsvskjnldsv self-assigned this May 29, 2025
@skjnldsv
skjnldsv requested a review from a team as a code ownerMay 29, 2025 09:14
@skjnldsv
skjnldsv requested review from nfebe, susnux and szaimen and removed request for a teamMay 29, 2025 09:14
@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels May 29, 2025
@skjnldsv

skjnldsv commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

/backport f69668216c7f25 to stable31

@skjnldsv

skjnldsv commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

/backport f69668216c7f25 to stable30

@skjnldsv
skjnldsvforce-pushed the fix/reset-property branch from e99316a to 6a5ab31CompareJune 1, 2025 10:17
@skjnldsv
skjnldsv requested review from artonge and susnuxJune 1, 2025 10:17
@nextcloud-command
nextcloud-command requested a review from a team as a code ownerJune 1, 2025 10:21
skjnldsvand others added 2 commits June 1, 2025 12:27
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsvforce-pushed the fix/reset-property branch from 2a256f6 to 16c7f25CompareJune 1, 2025 10:28
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
skjnldsv enabled auto-merge June 1, 2025 10:44
@skjnldsv
skjnldsv merged commit 6a9ae8b into masterJun 1, 2025
@skjnldsv
skjnldsv deleted the fix/reset-property branch June 1, 2025 12:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: profilePRs or issues related to the Profile feature (e.g. Profile page, API, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@AndyScherzinger@susnux@nextcloud-command