Uh oh!
There was an error while loading. Please reload this page.
fix(user_ldap): Harmonize parameter obfuscation and serialization accross logging methods - #53250
Merged
Merged
Conversation
…ross logging methods Debug log, profiler and ldap debug log had a different logic for sanitizing of parameters, aligning them. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
ArtificialOwl, icewind1991 and sorbaugh
and removed request for
a teamJune 2, 2025 09:49
come-nc
commented
Jun 2, 2025
ContributorAuthor
/backport to stable31 |
come-nc
commented
Jun 2, 2025
ContributorAuthor
/backport to stable30 |
come-nc
commented
Jun 2, 2025
ContributorAuthor
/backport to stable29 |
miaulalala
approved these changes
Jun 2, 2025
artonge
approved these changes
Jun 5, 2025
| 'func' => $functionName, | ||
| 'args' => json_encode($args), | ||
| ]); | ||
| if ($this->config->getSystemValue('loglevel') === ILogger::DEBUG) { |
Collaborator
There was a problem hiding this comment.
Why is this needed if we then call logger->debug()?
ContributorAuthor
There was a problem hiding this comment.
sanitizeFunctionParameters felt a bit expensive to run for nothing, so I wanted to only use the computing time if the log is actually gonna happen.
ContributorAuthor
There was a problem hiding this comment.
Actually the comment says just that on the line below: /* Only running this if debug loglevel is on, to avoid processing parameters on production */
This was referenced Jun 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debug log, profiler and ldap debug log had a different logic for
sanitizing of parameters, aligning them.
Checklist