Uh oh!
There was an error while loading. Please reload this page.
refactor(PreviewManager): Property promotion and array of classes - #53272
Closed
solracsf wants to merge 1 commit into
Closed
refactor(PreviewManager): Property promotion and array of classes#53272solracsf wants to merge 1 commit into
solracsf wants to merge 1 commit into
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
marked this pull request as ready for review
June 2, 2025 19:29
solracsf
requested review from
artonge, icewind1991 and provokateurin
and removed request for
a teamJune 2, 2025 19:29
kesselb
reviewed
Jun 3, 2025
| $this->registerCoreProvider(Preview\OpenDocument::class, '/application\/vnd.oasis.opendocument.*/'); | ||
| $this->registerCoreProvider(Preview\Imaginary::class, Preview\Imaginary::supportedMimeTypes()); | ||
| $this->registerCoreProvider(Preview\ImaginaryPDF::class, Preview\ImaginaryPDF::supportedMimeTypes()); | ||
| $mimeTypeConfig = [ |
Contributor
There was a problem hiding this comment.
I don't see how's that better than before?
Member
There was a problem hiding this comment.
Agreed, this just adds unnecessary lines of code 🤷♀️
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist