Skip to content

fix(accounts): new account quota value - #53273

Merged
SebastianKrupinski merged 2 commits into
masterfrom
fix/noid-fix-user-create-quota
Jun 3, 2025
Merged

fix(accounts): new account quota value#53273
SebastianKrupinski merged 2 commits into
masterfrom
fix/noid-fix-user-create-quota

Conversation

@SebastianKrupinski

@SebastianKrupinskiSebastianKrupinski commented Jun 2, 2025

Copy link
Copy Markdown
Contributor
  • Resolves: # Client Ticket

Summary

  • User quota was being displayed in GIB instead of GB

Before

image1

After

image

Checklist

@SebastianKrupinski
fix: new account quota value
fe4592c
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
SebastianKrupinski requested a review from a team as a code ownerJune 2, 2025 19:59
@SebastianKrupinski
SebastianKrupinski requested review from nfebe, susnux and szaimen and removed request for a teamJune 2, 2025 19:59
@SebastianKrupinskiSebastianKrupinski self-assigned this Jun 2, 2025
@SebastianKrupinskiSebastianKrupinski added the 3. to review Waiting for reviews label Jun 2, 2025
@SebastianKrupinski

SebastianKrupinski commented Jun 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/compile

@SebastianKrupinski

SebastianKrupinski commented Jun 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@nextcloud-command
chore(assets): Recompile assets
cefcb88
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command requested a review from a team as a code ownerJune 2, 2025 20:03
@SebastianKrupinskiSebastianKrupinski changed the title fix: new account quota valuefix(accounts): new account quota valueJun 2, 2025
@come-nc

come-nc commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

I thought it was GiB on server side 🤔
What is the frontend sending to the server in the end, "25GB", or a number of bytes?

@SebastianKrupinski

SebastianKrupinski commented Jun 3, 2025

Copy link
Copy Markdown
ContributorAuthor

I thought it was GiB on server side 🤔 What is the frontend sending to the server in the end, "25GB", or a number of bytes?

A string "25 GB" the UserRow in the user list does the same thing. I'm guessing this is a work around for 32bit support as an integer input would limit the input to 4GB. Idk I though it was odd we where using a string.

@SebastianKrupinski

SebastianKrupinski commented Jun 3, 2025

Copy link
Copy Markdown
ContributorAuthor

@come-nc can I get a second approval. Please

@szaimen
szaimen removed their request for review June 3, 2025 13:13
@SebastianKrupinski
SebastianKrupinski merged commit 604389c into masterJun 3, 2025
@SebastianKrupinski
SebastianKrupinski deleted the fix/noid-fix-user-create-quota branch June 3, 2025 14:52
@backportbotbackportbotBot mentioned this pull request Jun 3, 2025
Merged
2 tasks
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@come-nccome-nccome-nc approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@SebastianKrupinskiSebastianKrupinski

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SebastianKrupinski@come-nc@susnux@nextcloud-command